Revert "Reland "[base] Cleanup StackTraceTest.OutputToStream #ifdef soup.""
This reverts commit 06b27c6f. Reason for revert: This consistently fails under MSan with: ``` [ RUN ] StackTraceTest.OutputToStream ../../base/debug/stack_trace_unittest.cc:82: Failure Value of: backtrace_message.find("testing::Test::Run") != std::string::npos Actual: false Expected: true Expected a demangled symbol in backtrace: #0 0x5608768c4adb in backtrace /b/swarming/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:4101:13 #1 0x56087a80709b in base::debug::CollectStackTrace(void**, unsigned long) ./../../base/debug/stack_trace_posix.cc:840:39 #2 0x56087a45d4da in StackTrace ./../../base/debug/stack_trace.cc:206:12 #3 0x56087a45d4da in base::debug::StackTrace::StackTrace() ./../../base/debug/stack_trace.cc:203:28 #4 0x5608770e0c0f in base::debug::StackTraceTest_OutputToStream_Test::TestBody() ./../../base/debug/stack_trace_unittest.cc:39:14 #5 0x56087a2470c5 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #6 0x56087a2470c5 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2508:5 #7 0x56087a24abde in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2684:11 #8 0x56087a24c81a in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2816:28 #9 0x56087a28aa4a in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5338:44 #10 0x56087a288cae in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #11 0x56087a288cae in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:4925:10 #12 0x56087a9047a5 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2473:46 #13 0x56087a9047a5 in base::TestSuite::Run() ./../../base/test/test_suite.cc:394:16 #14 0x56087a98ce2a in Run ./../../base/callback.h:98:12 #15 0x56087a98ce2a in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, unsigned long, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:158:38 #16 0x56087a98c8bf in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>, unsigned long) ./../../base/test/launcher/unit_test_launcher.cc:228:10 #17 0x56087a8b39a0 in main ./../../base/test/run_all_base_unittests.cc:12:10 #18 0x7f4d99e7d830 in __libc_start_main ??:0:0 #19 0x56087688a67a in _start ??:0:0 Stack trace: #0 0x56087a45d4da in StackTrace ./../../base/debug/stack_trace.cc:206:12 #1 0x56087a45d4da in base::debug::StackTrace::StackTrace() ./../../base/debug/stack_trace.cc:203:28 #2 0x56087a1f22de in StackTraceGetter::CurrentStackTrace(int, int) ./../../third_party/googletest/custom/gtest/internal/custom/stack_trace_getter.cc:22:27 #3 0x56087a226149 in testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) ./../../third_party/googletest/src/googletest/src/gtest.cc:820:35 ``` (see https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8896945774609420288/+/steps/base_unittests/0/logs/Deterministic_failure:_StackTraceTest.OutputToStream__status_FAILURE_/0) Original change's description: > Reland "[base] Cleanup StackTraceTest.OutputToStream #ifdef soup." > > This was most recently reverted in > https://chromium-review.googlesource.com/c/chromium/src/+/1906545 > due to failures on some ChromeOS platforms, which lack the necessary > tables to allow stack-trace unwinding. > > Bug: 999737, 706728 > Change-Id: I7889416cd2ae9b6a09caf9eebb68a5ccf8bf4ca3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911680 > Auto-Submit: Wez <wez@chromium.org> > Commit-Queue: Albert J. Wong <ajwong@chromium.org> > Reviewed-by: Albert J. Wong <ajwong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714735} TBR=ajwong@chromium.org,wez@chromium.org Change-Id: I94bb1c35c8a8b205b72f4a7705996276453f9c2a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 999737, 706728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912704Reviewed-by:Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#714858}
Showing
Please register or sign in to comment