Skip to content

GitLab

T
tangled
Commit 04352adc authored by Nicolás Peña Moreno's avatar Nicolás Peña Moreno Committed by Commit Bot
Browse files
Options

[LargestContentfulPaint] Add multiple redirect test 

This CL adds the equivalent to element-timing/multiple-redirects for
LargestContentfulPaint. Since we use get-host-info instead of the .sub
commands, the .sub in the name is unneeded. This CL also updates the
expectations for disabled-OOR-CORS: the recent TAO tests will fail
without this flag enabled.

Bug: 1003943, 1042580
Change-Id: Ibc0b79d4c548fdbe9dc3eab6bd810f5a92425b35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010176Reviewed-by: default avatarYoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733408}
parent cbb29e49
Hide whitespace changes
Inline Side-by-side
Showing with 68 additions and 0 deletions
third_party/blink/web_tests/FlagExpectations/disable-features=OutOfBlinkCors
View file @ 04352adc
...@@ -34,3 +34,9 @@ crbug.com/870173 virtual/cache-storage-high-priority-match/external/wpt/service- ...@@ -34,3 +34,9 @@ crbug.com/870173 virtual/cache-storage-high-priority-match/external/wpt/service-
crbug.com/870173 virtual/cache-storage-sequence/external/wpt/service-workers/service-worker/fetch-request-xhr.https.html [ Failure ] crbug.com/870173 virtual/cache-storage-sequence/external/wpt/service-workers/service-worker/fetch-request-xhr.https.html [ Failure ]
crbug.com/870173 virtual/omt-service-worker-startup/external/wpt/service-workers/service-worker/fetch-request-xhr.https.html [ Failure ] crbug.com/870173 virtual/omt-service-worker-startup/external/wpt/service-workers/service-worker/fetch-request-xhr.https.html [ Failure ]
crbug.com/870173 virtual/omt-worker-fetch/external/wpt/service-workers/service-worker/fetch-request-xhr.https.html [ Failure ] crbug.com/870173 virtual/omt-worker-fetch/external/wpt/service-workers/service-worker/fetch-request-xhr.https.html [ Failure ]
# Timing-Allow-Origin checks are only completely correct with OOR-CORS.
crbug.com/1042580 external/wpt/element-timing/multiple-redirects-TAO.html [ Failure ]
crbug.com/1042580 external/wpt/element-timing/redirects-tao-star.html [ Failure ]
crbug.com/1042580 external/wpt/largest-contentful-paint/multiple-redirects-TAO.html [ Failure ]
crbug.com/1042580 external/wpt/largest-contentful-paint/redirects-tao-star.html [ Failure ]
third_party/blink/web_tests/external/wpt/largest-contentful-paint/multiple-redirects-TAO.html 0 → 100644
View file @ 04352adc
<!DOCTYPE HTML>
<html>
<head>
<meta charset="utf-8" />
<title>This test validates some Timing-Allow-Origin header usage in multiple redirects.</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="resources/largest-contentful-paint-helpers.js"></script>
<script src="/common/get-host-info.sub.js"></script>
</head>
<img id='image'></img>
<body>
<script>
async_test(t => {
assert_precondition(window.LargestContentfulPaint, "LargestContentfulPaint is not implemented");
let destUrl = get_host_info().HTTP_REMOTE_ORIGIN
+ '/element-timing/resources/multiple-redirects.py?';
destUrl += 'redirect_count=2';
// The final resource has '*' in TAO header, so will not affect the result.
destUrl += '&final_resource=/element-timing/resources/circle-tao.svg';
destUrl += '&origin1=' + get_host_info().UNAUTHENTICATED_ORIGIN;
destUrl += '&origin2=' + get_host_info().HTTP_REMOTE_ORIGIN;
const taoCombinations = [
{tao1: location.origin, tao2: location.origin, passes: false},
{tao1: location.origin, tao2: get_host_info().HTTP_REMOTE_ORIGIN, passes: false},
{tao1: location.origin, tao2: 'null', passes: true},
{tao1: location.origin, tao2: '*', passes: true},
{tao1: location.origin, tao2: location.origin, passes: false},
{tao1: 'null', tao2: '*', passes: false},
{tao1: '*', tao2: 'null', passes: true},
];
function getURL(item) {
return destUrl + '&tao1=' + item.tao1 + '&tao2=' + item.tao2;
}
function setImage(index) {
const image = document.getElementById('image');
const item = taoCombinations[index];
image.src = getURL(item);
}
let observedCount = 0;
let beforeLoad = performance.now();
new PerformanceObserver(t.step_func(entries => {
assert_equals(entries.getEntries().length, 1, 'There should be a single entry.');
const e = entries.getEntries()[0];
const item = taoCombinations[observedCount];
const url = getURL(item);
const options = item.passes ? [] : ['renderTimeIs0'];
checkImage(e, url, 'image', 200*200, beforeLoad, options);
observedCount++;
if (observedCount === taoCombinations.length) {
t.done();
} else {
beforeLoad = performance.now();
setImage(observedCount);
}
})).observe({entryTypes: ['largest-contentful-paint']});
setImage(0);
}, 'Cross-origin images with passing/failing TAO should/shouldn\'t have its renderTime set.');
</script>
</body>
</html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment