Commit 0439b51a authored by Xing Xu's avatar Xing Xu Committed by Commit Bot

Edit optimization guide proto for public HTTPS image compression.

Bug: 1036490
Change-Id: I5bd567c66f43e5c8c1b4149e6f05125c7ccf9700
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988717
Commit-Queue: Xing Xu <xingx@chromium.org>
Reviewed-by: default avatarSophie Chang <sophiechang@chromium.org>
Reviewed-by: default avatarTarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729836}
parent 3850d26c
...@@ -39,6 +39,8 @@ std::string GetStringNameForOptimizationType( ...@@ -39,6 +39,8 @@ std::string GetStringNameForOptimizationType(
return "PerformanceHints"; return "PerformanceHints";
case proto::OptimizationType::LITE_PAGE: case proto::OptimizationType::LITE_PAGE:
return "LitePage"; return "LitePage";
case proto::OptimizationType::COMPRESS_PUBLIC_IMAGES:
return "CompressPublicImages";
} }
NOTREACHED(); NOTREACHED();
return std::string(); return std::string();
......
...@@ -12,5 +12,6 @@ proto_library("optimization_guide_proto") { ...@@ -12,5 +12,6 @@ proto_library("optimization_guide_proto") {
"models.proto", "models.proto",
"performance_hints_metadata.proto", "performance_hints_metadata.proto",
"previews_metadata.proto", "previews_metadata.proto",
"public_image_metadata.proto",
] ]
} }
...@@ -10,6 +10,7 @@ package optimization_guide.proto; ...@@ -10,6 +10,7 @@ package optimization_guide.proto;
import "common_types.proto"; import "common_types.proto";
import "performance_hints_metadata.proto"; import "performance_hints_metadata.proto";
import "previews_metadata.proto"; import "previews_metadata.proto";
import "public_image_metadata.proto";
// Information about the hint that the client already has for a host. // Information about the hint that the client already has for a host.
message MatchedHintInfo { message MatchedHintInfo {
...@@ -127,6 +128,8 @@ enum OptimizationType { ...@@ -127,6 +128,8 @@ enum OptimizationType {
// This optimization allows page loads going through the data reduction // This optimization allows page loads going through the data reduction
// proxy to be transformed by the proxy. // proxy to be transformed by the proxy.
LITE_PAGE = 7; LITE_PAGE = 7;
// This optimization compresses public images.
COMPRESS_PUBLIC_IMAGES = 8;
} }
// Presents semantics for how page load URLs should be matched. // Presents semantics for how page load URLs should be matched.
...@@ -189,6 +192,7 @@ message Optimization { ...@@ -189,6 +192,7 @@ message Optimization {
oneof metadata { oneof metadata {
PreviewsMetadata previews_metadata = 10; PreviewsMetadata previews_metadata = 10;
PerformanceHintsMetadata performance_hints_metadata = 11; PerformanceHintsMetadata performance_hints_metadata = 11;
PublicImageMetadata public_image_metadata = 12;
} }
} }
......
// Copyright 2020 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
syntax = "proto2";
option optimize_for = LITE_RUNTIME;
package optimization_guide.proto;
// Optimization metadata for compressing public images.
//
// This is populated for optimization type COMPRESS_PUBLIC_IMAGES.
message PublicImageMetadata {
repeated string url = 1;
}
...@@ -183457,6 +183457,7 @@ regressions. --> ...@@ -183457,6 +183457,7 @@ regressions. -->
</histogram_suffixes> </histogram_suffixes>
<histogram_suffixes name="OptimizationGuide.OptimizationTypes" separator="."> <histogram_suffixes name="OptimizationGuide.OptimizationTypes" separator=".">
<suffix name="CompressPublicImages" label="Compresses public images"/>
<suffix name="DeferAllScript" label="Defers execution of script"/> <suffix name="DeferAllScript" label="Defers execution of script"/>
<suffix name="LitePage" <suffix name="LitePage"
label="HTTP server preview (served from the Data Reduction Proxy)"/> label="HTTP server preview (served from the Data Reduction Proxy)"/>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment