Commit 0452174c authored by Robert Ogden's avatar Robert Ogden Committed by Commit Bot

Reenable LitePagePreviewsReportSavings test

This test was flaky because the reported data savings was sometimes
zero. I was unable to repro locally, but adding another navigation
afterwards should help a lot and I'll keep tabs on it with FindIt.

Bug: 915775
Change-Id: Ib55370ed3ccdd4e047acfe30ca342d9693a560bc
Reviewed-on: https://chromium-review.googlesource.com/c/1392598Reviewed-by: default avatarTarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619496}
parent c6115abf
...@@ -1122,10 +1122,8 @@ IN_PROC_BROWSER_TEST_F(PreviewsLitePageServerBrowserTest, ...@@ -1122,10 +1122,8 @@ IN_PROC_BROWSER_TEST_F(PreviewsLitePageServerBrowserTest,
ClearDeciderState(); ClearDeciderState();
} }
// This was previously marked DISABLE_ON_WIN_MAC(), but the test is also failing
// flakily on Linux, so now it is completely disabled. https://crbug.com/915775
IN_PROC_BROWSER_TEST_F(PreviewsLitePageServerBrowserTest, IN_PROC_BROWSER_TEST_F(PreviewsLitePageServerBrowserTest,
DISABLED_LitePagePreviewsReportSavings) { DISABLE_ON_WIN_MAC(LitePagePreviewsReportSavings)) {
PrefService* prefs = browser()->profile()->GetPrefs(); PrefService* prefs = browser()->profile()->GetPrefs();
prefs->SetBoolean(data_reduction_proxy::prefs::kDataUsageReportingEnabled, prefs->SetBoolean(data_reduction_proxy::prefs::kDataUsageReportingEnabled,
true); true);
...@@ -1137,6 +1135,10 @@ IN_PROC_BROWSER_TEST_F(PreviewsLitePageServerBrowserTest, ...@@ -1137,6 +1135,10 @@ IN_PROC_BROWSER_TEST_F(PreviewsLitePageServerBrowserTest,
ui_test_utils::NavigateToURL(browser(), HttpsLitePageURL(kSuccess)); ui_test_utils::NavigateToURL(browser(), HttpsLitePageURL(kSuccess));
VerifyPreviewLoaded(); VerifyPreviewLoaded();
// Navigate to an untracked (no preview) page before checking reported savings
// to reduce flakiness.
ui_test_utils::NavigateToURL(browser(), GURL("http://www.google.com"));
EXPECT_EQ(GetTotalOriginalContentLength() - GetTotalDataUsage(), 40U); EXPECT_EQ(GetTotalOriginalContentLength() - GetTotalDataUsage(), 40U);
EXPECT_EQ(GetDataUsage(), 20U); EXPECT_EQ(GetDataUsage(), 20U);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment