Skip to content

GitLab

T
tangled
Commit 04529c04 authored by Nidhi Jaju's avatar Nidhi Jaju Committed by Commit Bot
Browse files
Options

Reland "Remove NotEnumerable from Transform Streams WebIDL" 

This is a reland of b52b97cb

Original change's description:
> Remove NotEnumerable from Transform Streams WebIDL
>
> According to https://github.com/whatwg/streams/pull/1035, all methods
> and accessors are now enumerable, per Web IDL defaults, instead of
> non-enumerable, per ECMAScript defaults. Hence, 'NotEnumerable' can
> be removed from the Streams WebIDL files. This CL specifically
> removes them from transform streams.
>
> Bug: 1093862
> Change-Id: I509b470722039ebad20b8caeaa7f34189c24b1ba
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486006
> Commit-Queue: Nidhi Jaju <nidhijaju@google.com>
> Reviewed-by: Adam Rice <ricea@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#819230}

Bug: 1093862
Change-Id: Ic3d119e1c5d2192a3159fb672a5782fa2af8aedc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488946
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: default avatarAdam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819380}
parent 5ce796bc
Hide whitespace changes
Inline Side-by-side
Showing with 18 additions and 18 deletions
third_party/blink/renderer/core/streams/transform_stream.idl
View file @ 04529c04
......@@ -9,6 +9,6 @@
[CallWith=ScriptState, RaisesException] constructor(optional any transformer,
optional any writableStrategy,
optional any readableStrategy);
[NotEnumerable] readonly attribute ReadableStream readable;
[NotEnumerable] readonly attribute WritableStream writable;
readonly attribute ReadableStream readable;
readonly attribute WritableStream writable;
};
third_party/blink/renderer/core/streams/transform_stream_default_controller.idl
View file @ 04529c04
......@@ -6,9 +6,9 @@
// https://streams.spec.whatwg.org/#rs-default-controller-class-definition
interface TransformStreamDefaultController {
[NotEnumerable] readonly attribute double? desiredSize;
[CallWith=ScriptState, NotEnumerable, RaisesException] void enqueue(
readonly attribute double? desiredSize;
[CallWith=ScriptState, RaisesException] void enqueue(
optional any chunk);
[CallWith=ScriptState, NotEnumerable] void error(optional any reason);
[CallWith=ScriptState, NotEnumerable] void terminate();
[CallWith=ScriptState] void error(optional any reason);
[CallWith=ScriptState] void terminate();
};
third_party/blink/web_tests/external/wpt/streams/idlharness.any-expected.txt
View file @ 04529c04
This is a testharness.js-based test.
Found 224 tests; 126 PASS, 98 FAIL, 0 TIMEOUT, 0 NOTRUN.
Found 224 tests; 128 PASS, 96 FAIL, 0 TIMEOUT, 0 NOTRUN.
PASS idl_test setup
PASS idl_test validation
PASS ReadableStreamDefaultReader includes ReadableStreamGenericReader: member names are unique
......@@ -176,8 +176,8 @@ PASS TransformStream interface object name
PASS TransformStream interface: existence and properties of interface prototype object
PASS TransformStream interface: existence and properties of interface prototype object's "constructor" property
PASS TransformStream interface: existence and properties of interface prototype object's @@unscopables property
FAIL TransformStream interface: attribute readable assert_true: property should be enumerable expected true got false
FAIL TransformStream interface: attribute writable assert_true: property should be enumerable expected true got false
PASS TransformStream interface: attribute readable
PASS TransformStream interface: attribute writable
PASS TransformStream must be primary interface of new TransformStream()
PASS Stringification of new TransformStream()
PASS TransformStream interface: new TransformStream() must inherit property "readable" with the proper type
......
third_party/blink/web_tests/external/wpt/streams/idlharness.any.serviceworker-expected.txt
View file @ 04529c04
This is a testharness.js-based test.
Found 224 tests; 126 PASS, 98 FAIL, 0 TIMEOUT, 0 NOTRUN.
Found 224 tests; 128 PASS, 96 FAIL, 0 TIMEOUT, 0 NOTRUN.
PASS idl_test setup
PASS idl_test validation
PASS ReadableStreamDefaultReader includes ReadableStreamGenericReader: member names are unique
......@@ -176,8 +176,8 @@ PASS TransformStream interface object name
PASS TransformStream interface: existence and properties of interface prototype object
PASS TransformStream interface: existence and properties of interface prototype object's "constructor" property
PASS TransformStream interface: existence and properties of interface prototype object's @@unscopables property
FAIL TransformStream interface: attribute readable assert_true: property should be enumerable expected true got false
FAIL TransformStream interface: attribute writable assert_true: property should be enumerable expected true got false
PASS TransformStream interface: attribute readable
PASS TransformStream interface: attribute writable
PASS TransformStream must be primary interface of new TransformStream()
PASS Stringification of new TransformStream()
PASS TransformStream interface: new TransformStream() must inherit property "readable" with the proper type
......
third_party/blink/web_tests/external/wpt/streams/idlharness.any.sharedworker-expected.txt
View file @ 04529c04
This is a testharness.js-based test.
Found 224 tests; 126 PASS, 98 FAIL, 0 TIMEOUT, 0 NOTRUN.
Found 224 tests; 128 PASS, 96 FAIL, 0 TIMEOUT, 0 NOTRUN.
PASS idl_test setup
PASS idl_test validation
PASS ReadableStreamDefaultReader includes ReadableStreamGenericReader: member names are unique
......@@ -176,8 +176,8 @@ PASS TransformStream interface object name
PASS TransformStream interface: existence and properties of interface prototype object
PASS TransformStream interface: existence and properties of interface prototype object's "constructor" property
PASS TransformStream interface: existence and properties of interface prototype object's @@unscopables property
FAIL TransformStream interface: attribute readable assert_true: property should be enumerable expected true got false
FAIL TransformStream interface: attribute writable assert_true: property should be enumerable expected true got false
PASS TransformStream interface: attribute readable
PASS TransformStream interface: attribute writable
PASS TransformStream must be primary interface of new TransformStream()
PASS Stringification of new TransformStream()
PASS TransformStream interface: new TransformStream() must inherit property "readable" with the proper type
......
third_party/blink/web_tests/external/wpt/streams/idlharness.any.worker-expected.txt
View file @ 04529c04
This is a testharness.js-based test.
Found 224 tests; 126 PASS, 98 FAIL, 0 TIMEOUT, 0 NOTRUN.
Found 224 tests; 128 PASS, 96 FAIL, 0 TIMEOUT, 0 NOTRUN.
PASS idl_test setup
PASS idl_test validation
PASS ReadableStreamDefaultReader includes ReadableStreamGenericReader: member names are unique
......@@ -176,8 +176,8 @@ PASS TransformStream interface object name
PASS TransformStream interface: existence and properties of interface prototype object
PASS TransformStream interface: existence and properties of interface prototype object's "constructor" property
PASS TransformStream interface: existence and properties of interface prototype object's @@unscopables property
FAIL TransformStream interface: attribute readable assert_true: property should be enumerable expected true got false
FAIL TransformStream interface: attribute writable assert_true: property should be enumerable expected true got false
PASS TransformStream interface: attribute readable
PASS TransformStream interface: attribute writable
PASS TransformStream must be primary interface of new TransformStream()
PASS Stringification of new TransformStream()
PASS TransformStream interface: new TransformStream() must inherit property "readable" with the proper type
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment