Add icons to remote_assistance_host bundle.

The IT2Me host bundle did not have any bundle icon. This bundle appears in
Security & Privacy permissions lists with a stock Apple icon, so this
CL adds a proper .icns file to the bundle.

Change-Id: I115f35e2cfeaccd402064d1403a9ce26f08a63bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918026
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Gary Kacmarcik <garykac@chromium.org>
Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715507}

remoting/host/it2me/BUILD.gn

@@ -145,8 +145,9 @@ if (!is_chromeos && enable_remoting_host) {
     if (is_mac) {
       app_target_type = "mac_app_bundle"
 
-      bundle_data("remote_assistance_host_dialog_icon") {
+      bundle_data("remote_assistance_host_icons") {
         sources = [
+          "//remoting/host/mac/remoting_host.icns",
           "//remoting/resources/chromoting128.png",
         ]
 
@@ -231,7 +232,7 @@ if (!is_chromeos && enable_remoting_host) {
           ]
         }
         deps += [
-          ":remote_assistance_host_dialog_icon",
+          ":remote_assistance_host_icons",
           "//remoting/host:remoting_infoplist_strings",
           "//remoting/host/mac:permission_checking",
           "//remoting/resources:copy_locales",

remoting/host/it2me/remote_assistance_host-Info.plist

@@ -7,7 +7,7 @@
   <key>CFBundleExecutable</key>
   <string>${EXECUTABLE_NAME}</string>
   <key>CFBundleIconFile</key>
-  <string>remote_assistance_host</string>
+  <string>remoting_host</string>
   <key>CFBundleIdentifier</key>
   <string>${BUNDLE_ID}</string>
   <key>CFBundleInfoDictionaryVersion</key>

remoting/host/mac/BUILD.gn

@@ -81,7 +81,7 @@ foreach(locale, remoting_locales_with_underscores) {
 bundle_data("remoting_host_resources") {
   sources = [
     "$root_gen_dir/remoting/CREDITS.txt",
-    "remoting_me2me_host.icns",
+    "remoting_host.icns",
   ]
 
   outputs = [
@@ -167,7 +167,7 @@ foreach(locale, remoting_locales_with_underscores) {
 
 bundle_data("remoting_native_messaging_host_resources") {
   sources = [
-    "//remoting/host/mac/remoting_me2me_host.icns",
+    "remoting_host.icns",
 
     # This image is used to badge the lock icon in the authentication dialogs,
     # used for elevating privileges to set up the host. The exact filename is

remoting/host/mac/remoting_me2me_host-Info.plist

@@ -7,7 +7,7 @@
   <key>CFBundleExecutable</key>
   <string>${EXECUTABLE_NAME}</string>
   <key>CFBundleIconFile</key>
-  <string>remoting_me2me_host</string>
+  <string>remoting_host</string>
   <key>CFBundleIdentifier</key>
   <string>${BUNDLE_ID}</string>
   <key>CFBundleInfoDictionaryVersion</key>

remoting/host/setup/native_messaging_host-Info.plist

@@ -7,7 +7,7 @@
   <key>CFBundleExecutable</key>
   <string>${EXECUTABLE_NAME}</string>
   <key>CFBundleIconFile</key>
-  <string>remoting_me2me_host</string>
+  <string>remoting_host</string>
   <key>CFBundleIdentifier</key>
   <string>${BUNDLE_ID}</string>
   <key>CFBundleInfoDictionaryVersion</key>