Commit 04849ae1 authored by Hannes Payer's avatar Hannes Payer Committed by Commit Bot

Adding V8 code large object space metrics.

Privacy review doc: https://goo.gl/X5eYHh

Change-Id: Ic99b316b1ab2fe665670f0131f8255b9ac4b0395
Reviewed-on: https://chromium-review.googlesource.com/c/1345434Reviewed-by: default avatarUlan Degenbaev <ulan@chromium.org>
Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610094}
parent 8aa2d8cb
...@@ -174,6 +174,15 @@ const Metric kAllocatorDumpNamesForMetrics[] = { ...@@ -174,6 +174,15 @@ const Metric kAllocatorDumpNamesForMetrics[] = {
{"v8/main/heap", "V8.Main.Heap.AllocatedObjects", kLargeMetric, {"v8/main/heap", "V8.Main.Heap.AllocatedObjects", kLargeMetric,
kAllocatedObjectsSize, EmitTo::kUkmAndUmaAsSize, kAllocatedObjectsSize, EmitTo::kUkmAndUmaAsSize,
&Memory_Experimental::SetV8_Main_Heap_AllocatedObjects}, &Memory_Experimental::SetV8_Main_Heap_AllocatedObjects},
{"v8/main/heap/code_large_object_space",
"V8.Main.Heap.CodeLargeObjectSpace", kLargeMetric, kEffectiveSize,
EmitTo::kUkmAndUmaAsSize,
&Memory_Experimental::SetV8_Main_Heap_CodeLargeObjectSpace},
{"v8/main/heap/code_large_object_space",
"V8.Main.Heap.CodeLargeObjectSpace.AllocatedObjects", kLargeMetric,
kAllocatedObjectsSize, EmitTo::kUkmAndUmaAsSize,
&Memory_Experimental::
SetV8_Main_Heap_CodeLargeObjectSpace_AllocatedObjects},
{"v8/main/heap/code_space", "V8.Main.Heap.CodeSpace", kLargeMetric, {"v8/main/heap/code_space", "V8.Main.Heap.CodeSpace", kLargeMetric,
kEffectiveSize, EmitTo::kUkmAndUmaAsSize, kEffectiveSize, EmitTo::kUkmAndUmaAsSize,
&Memory_Experimental::SetV8_Main_Heap_CodeSpace}, &Memory_Experimental::SetV8_Main_Heap_CodeSpace},
......
...@@ -196,6 +196,15 @@ void PopulateRendererMetrics(GlobalMemoryDumpPtr& global_dump, ...@@ -196,6 +196,15 @@ void PopulateRendererMetrics(GlobalMemoryDumpPtr& global_dump,
pmd, "v8/main/heap", "allocated_objects_size", pmd, "v8/main/heap", "allocated_objects_size",
metrics_mb_or_count["V8.Main.Heap.AllocatedObjects"] * 1024 * 1024); metrics_mb_or_count["V8.Main.Heap.AllocatedObjects"] * 1024 * 1024);
SetAllocatorDumpMetric(
pmd, "v8/main/heap/code_large_object_space", "effective_size",
metrics_mb_or_count["V8.Main.Heap.CodeLargeObjectSpace"] * 1024 * 1024);
SetAllocatorDumpMetric(
pmd, "v8/main/heap/code_large_object_space", "allocated_objects_size",
metrics_mb_or_count
["V8.Main.Heap.CodeLargeObjectSpace.AllocatedObjects"] *
1024 * 1024);
SetAllocatorDumpMetric( SetAllocatorDumpMetric(
pmd, "v8/main/heap/code_space", "effective_size", pmd, "v8/main/heap/code_space", "effective_size",
metrics_mb_or_count["V8.Main.Heap.CodeSpace"] * 1024 * 1024); metrics_mb_or_count["V8.Main.Heap.CodeSpace"] * 1024 * 1024);
......
...@@ -2716,6 +2716,18 @@ be describing additional metrics about the same event. ...@@ -2716,6 +2716,18 @@ be describing additional metrics about the same event.
Measure of memory consumed by live objects in the main heap of V8. Measure of memory consumed by live objects in the main heap of V8.
</summary> </summary>
</metric> </metric>
<metric name="V8.Main.Heap.CodeLargeObjectSpace">
<summary>
Measure of memory consumed by the code large object space of the main heap
of V8.
</summary>
</metric>
<metric name="V8.Main.Heap.CodeLargeObjectSpace.AllocatedObjects">
<summary>
Measure of memory consumed by live objects in the code large object space
of the main heap of V8.
</summary>
</metric>
<metric name="V8.Main.Heap.CodeSpace"> <metric name="V8.Main.Heap.CodeSpace">
<summary> <summary>
Measure of memory consumed by the code space of the main heap of V8. Measure of memory consumed by the code space of the main heap of V8.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment