Commit 0498cd9b authored by Jared Saul's avatar Jared Saul Committed by Commit Bot

Revert "[Sheriff] Disable Logic_CanOfferToSaveDynamicForm on Linux"

This reverts commit c85cb465.

Reason for revert: The test failure that instigated this CL impacted several tests, not just ours, and was seemingly unrelated to our code area.  Additionally, another CL that disabled a test for the same failure report disabled the *wrong* test and was subsequently reverted, further implying that the original failure was only temporary (as its offending test was never actually disabled).

Original change's description:
> [Sheriff] Disable Logic_CanOfferToSaveDynamicForm on Linux
> 
> TBR=estade@chromium.org
> 
> Bug: 1017819
> Change-Id: I8d5f2acbe8c30c5998e8c5a4ebd83c95a555a8a8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879692
> Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
> Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#709124}

TBR=estade@chromium.org,smcgruer@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1017819
Change-Id: Ie76f07d43b6fd71ecf86b1b6a902d1a7924b2521
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900129Reviewed-by: default avatarJared Saul <jsaul@google.com>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#712840}
parent 988465ae
...@@ -1927,19 +1927,11 @@ IN_PROC_BROWSER_TEST_F( ...@@ -1927,19 +1927,11 @@ IN_PROC_BROWSER_TEST_F(
SubmitFormAndWaitForCardUploadSaveBubble(); SubmitFormAndWaitForCardUploadSaveBubble();
} }
// TODO(crbug.com/1017819): Flaky-crashing on Linux
#if defined(OS_LINUX)
#define MAYBE_Logic_CanOfferToSaveDynamicForm \
DISABLED_Logic_CanOfferToSaveDynamicForm
#else
#define MAYBE_Logic_CanOfferToSaveDynamicForm Logic_CanOfferToSaveDynamicForm
#endif
// Tests the upload save logic. Ensures that Chrome offers a upload save for // Tests the upload save logic. Ensures that Chrome offers a upload save for
// dynamic change form. // dynamic change form.
IN_PROC_BROWSER_TEST_F( IN_PROC_BROWSER_TEST_F(
SaveCardBubbleViewsFullFormBrowserTestWithAutofillUpstream, SaveCardBubbleViewsFullFormBrowserTestWithAutofillUpstream,
MAYBE_Logic_CanOfferToSaveDynamicForm) { Logic_CanOfferToSaveDynamicForm) {
// Start sync. // Start sync.
harness_->SetupSync(); harness_->SetupSync();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment