Commit 04a8b5d8 authored by Monica Basta's avatar Monica Basta Committed by Commit Bot

[SyncSetup]: Remove redundant user action.

This CL removes 'Sync_NavigateToSyncAdvancedPage' user action.
As navigation to chrome settings routes are recorded in
'WebUI.Settings.PathVisited' histogram.

Bug: 1050070
Change-Id: Iea2dfc812a78df6c1ad7cb733b972d75d57f0ffa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115470Reviewed-by: default avatarEsmael Elmoslimany <aee@chromium.org>
Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752818}
parent 96814e00
...@@ -39,7 +39,7 @@ const RadioButtonNames = { ...@@ -39,7 +39,7 @@ const RadioButtonNames = {
Polymer({ Polymer({
is: 'settings-sync-controls', is: 'settings-sync-controls',
behaviors: [WebUIListenerBehavior, settings.RouteObserverBehavior], behaviors: [WebUIListenerBehavior],
properties: { properties: {
hidden: { hidden: {
...@@ -103,14 +103,6 @@ Polymer({ ...@@ -103,14 +103,6 @@ Polymer({
} }
}, },
/** @protected */
currentRouteChanged() {
const router = settings.Router.getInstance();
if (router.getCurrentRoute() === router.getRoutes().SYNC_ADVANCED) {
chrome.metricsPrivate.recordUserAction('Sync_NavigateToSyncAdvancedPage');
}
},
/** /**
* Handler for when the sync preferences are updated. * Handler for when the sync preferences are updated.
* @private * @private
......
...@@ -22673,6 +22673,10 @@ should be able to be added at any place in this file. ...@@ -22673,6 +22673,10 @@ should be able to be added at any place in this file.
</action> </action>
<action name="Sync_NavigateToSyncAdvancedPage"> <action name="Sync_NavigateToSyncAdvancedPage">
<obsolete>
Deprecated as of 03/2020. Navigation to settings routes are recorded in
WebUI.Settings.PathVisited histogram.
</obsolete>
<owner>msalama@chromium.org</owner> <owner>msalama@chromium.org</owner>
<owner>chrome-signin-team@google.com</owner> <owner>chrome-signin-team@google.com</owner>
<description> <description>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment