Commit 04d6dc2f authored by Xing Liu's avatar Xing Liu Committed by Commit Bot

Background download: Add trace events to debug jank.

This CL adds 3 trace event in background download system to debug
potential jank reporting through crash report.

Bug: 878593
Change-Id: Ibebca6ba331fb00b5b74a327b900c98e8b516151
Reviewed-on: https://chromium-review.googlesource.com/c/1354638Reviewed-by: default avatarssid <ssid@chromium.org>
Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612356}
parent f166971a
...@@ -5,6 +5,7 @@ ...@@ -5,6 +5,7 @@
#include "chrome/browser/android/download/service/download_task_scheduler.h" #include "chrome/browser/android/download/service/download_task_scheduler.h"
#include "base/android/jni_android.h" #include "base/android/jni_android.h"
#include "base/trace_event/trace_event.h"
#include "jni/DownloadTaskScheduler_jni.h" #include "jni/DownloadTaskScheduler_jni.h"
namespace download { namespace download {
...@@ -28,6 +29,8 @@ void DownloadTaskScheduler::ScheduleTask(DownloadTaskType task_type, ...@@ -28,6 +29,8 @@ void DownloadTaskScheduler::ScheduleTask(DownloadTaskType task_type,
} }
void DownloadTaskScheduler::CancelTask(DownloadTaskType task_type) { void DownloadTaskScheduler::CancelTask(DownloadTaskType task_type) {
TRACE_EVENT0("download_service", "DownloadTaskScheduler.CancelTask");
JNIEnv* env = base::android::AttachCurrentThread(); JNIEnv* env = base::android::AttachCurrentThread();
Java_DownloadTaskScheduler_cancelTask(env, static_cast<jint>(task_type)); Java_DownloadTaskScheduler_cancelTask(env, static_cast<jint>(task_type));
} }
......
...@@ -5,6 +5,7 @@ ...@@ -5,6 +5,7 @@
#include "components/download/internal/background_service/android/battery_status_listener_android.h" #include "components/download/internal/background_service/android/battery_status_listener_android.h"
#include "base/android/jni_android.h" #include "base/android/jni_android.h"
#include "base/trace_event/trace_event.h"
#include "jni/BatteryStatusListenerAndroid_jni.h" #include "jni/BatteryStatusListenerAndroid_jni.h"
namespace download { namespace download {
...@@ -16,6 +17,8 @@ BatteryStatusListenerAndroid::BatteryStatusListenerAndroid( ...@@ -16,6 +17,8 @@ BatteryStatusListenerAndroid::BatteryStatusListenerAndroid(
BatteryStatusListenerAndroid::~BatteryStatusListenerAndroid() = default; BatteryStatusListenerAndroid::~BatteryStatusListenerAndroid() = default;
int BatteryStatusListenerAndroid::GetBatteryPercentageInternal() { int BatteryStatusListenerAndroid::GetBatteryPercentageInternal() {
TRACE_EVENT0("download_service",
"BatteryStatusListenerAndroid.GetBatteryPercentageInternal");
return Java_BatteryStatusListenerAndroid_getBatteryPercentage( return Java_BatteryStatusListenerAndroid_getBatteryPercentage(
base::android::AttachCurrentThread()); base::android::AttachCurrentThread());
} }
......
...@@ -5,6 +5,7 @@ ...@@ -5,6 +5,7 @@
#include "components/download/internal/background_service/android/network_status_listener_android.h" #include "components/download/internal/background_service/android/network_status_listener_android.h"
#include "base/android/jni_android.h" #include "base/android/jni_android.h"
#include "base/trace_event/trace_event.h"
#include "jni/NetworkStatusListenerAndroid_jni.h" #include "jni/NetworkStatusListenerAndroid_jni.h"
namespace download { namespace download {
...@@ -25,8 +26,9 @@ void NetworkStatusListenerAndroid::NotifyNetworkChange( ...@@ -25,8 +26,9 @@ void NetworkStatusListenerAndroid::NotifyNetworkChange(
void NetworkStatusListenerAndroid::Start( void NetworkStatusListenerAndroid::Start(
NetworkStatusListener::Observer* observer) { NetworkStatusListener::Observer* observer) {
NetworkStatusListener::Start(observer); TRACE_EVENT0("download_service", "NetworkStatusListenerAndroid.Start");
NetworkStatusListener::Start(observer);
JNIEnv* env = base::android::AttachCurrentThread(); JNIEnv* env = base::android::AttachCurrentThread();
java_obj_.Reset(env, Java_NetworkStatusListenerAndroid_create( java_obj_.Reset(env, Java_NetworkStatusListenerAndroid_create(
env, reinterpret_cast<intptr_t>(this)) env, reinterpret_cast<intptr_t>(this))
......
...@@ -40,11 +40,11 @@ const base::FilePath::CharType kAndroidTraceConfigFile[] = ...@@ -40,11 +40,11 @@ const base::FilePath::CharType kAndroidTraceConfigFile[] =
const char kDefaultStartupCategories[] = const char kDefaultStartupCategories[] =
"startup,browser,toplevel,EarlyJava,cc,Java,navigation,loading,gpu," "startup,browser,toplevel,EarlyJava,cc,Java,navigation,loading,gpu,"
"disabled-by-default-cpu_profiler,-*"; "disabled-by-default-cpu_profiler,download_service,-*";
#else #else
const char kDefaultStartupCategories[] = const char kDefaultStartupCategories[] =
"benchmark,toplevel,startup,disabled-by-default-file,disabled-by-default-" "benchmark,toplevel,startup,disabled-by-default-file,disabled-by-default-"
"toplevel.flow,disabled-by-default-ipc.flow,-*"; "toplevel.flow,disabled-by-default-ipc.flow,download_service,-*";
#endif #endif
// String parameters that can be used to parse the trace config file content. // String parameters that can be used to parse the trace config file content.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment