AW: scheduleInvalidate() when native want the handles to show.
|PopupTouchHandleDrawable| is reacting to both native and Java for its visibility. When WebView is moved under other window/view, Java side will hide the handles and set their visiblity to |INVISIBLE|. Previously, Java setOrigin() only do invalidation when the view is visible, but if we do a selection and move the selection to under other window, and then do another selection, the visiblity will be preserved, so handles are not showing again. Native treated the second selection as selection handles moved event, there is no need to update the visibility from native's perspective. We should scheduleInvalidate() when native thinks the handle should be visible, scheduleInvalidate() will calculate the real visiblitiy against the current view hierarchy and do invalidation if necessary. Bug: 808701 Change-Id: I50dfa80d0299fd4692abba2c33b8a335bd455372 Reviewed-on: https://chromium-review.googlesource.com/1026834Reviewed-by:Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#553789}
Showing
Please register or sign in to comment