Rename mojo DNS config notification

DnsConfigChangeManagerClient::OnSystemDnsConfigChanged ->
DnsConfigChangeManagerClient::OnDnsConfigChanged because, as of
crrev.com/c/1783280, such notifications can now include non-system
changes added by the Chrome net stack to the effective config.

TBR=jam@chromium.org

Bug: 971411
Change-Id: If46b175497a5995442e52f66152d065b0ec9b61d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787999
Commit-Queue: Eric Orth <ericorth@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Auto-Submit: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711437}

chrome/browser/intranet_redirect_detector.cc

@@ -217,7 +217,7 @@ void IntranetRedirectDetector::OnConnectionChanged(
     Restart();
 }
 
-void IntranetRedirectDetector::OnSystemDnsConfigChanged() {
+void IntranetRedirectDetector::OnDnsConfigChanged() {
   Restart();
 }
 

chrome/browser/intranet_redirect_detector.h

@@ -77,7 +77,7 @@ class IntranetRedirectDetector
   void OnConnectionChanged(network::mojom::ConnectionType type) override;
 
   // network::mojom::DnsConfigChangeManagerClient
-  void OnSystemDnsConfigChanged() override;
+  void OnDnsConfigChanged() override;
 
   void SetupDnsConfigClient();
   void OnDnsConfigClientConnectionError();

chrome/browser/net/dns_probe_service_factory.cc

@@ -137,7 +137,7 @@ class DnsProbeServiceImpl
   void ProbeDns(DnsProbeService::ProbeCallback callback) override;
 
   // mojom::network::DnsConfigChangeManagerClient implementation:
-  void OnSystemDnsConfigChanged() override;
+  void OnDnsConfigChanged() override;
 
  private:
   enum State {
@@ -225,7 +225,7 @@ void DnsProbeServiceImpl::ProbeDns(ProbeCallback callback) {
   }
 }
 
-void DnsProbeServiceImpl::OnSystemDnsConfigChanged() {
+void DnsProbeServiceImpl::OnDnsConfigChanged() {
   ClearCachedResult();
 }
 

chrome/browser/net/dns_probe_test_util.cc

@@ -133,7 +133,7 @@ void FakeDnsConfigChangeManager::RequestNotifications(
 
 void FakeDnsConfigChangeManager::SimulateDnsConfigChange() {
   ASSERT_TRUE(client_);
-  client_->OnSystemDnsConfigChanged();
+  client_->OnDnsConfigChanged();
 }
 
 }  // namespace chrome_browser_net

services/network/dns_config_change_manager.cc

@@ -28,7 +28,7 @@ void DnsConfigChangeManager::RequestNotifications(
 
 void DnsConfigChangeManager::OnDNSChanged() {
   for (const auto& client : clients_)
-    client->OnSystemDnsConfigChanged();
+    client->OnDnsConfigChanged();
 }
 
 }  // namespace network

services/network/dns_config_change_manager_unittest.cc

@@ -24,7 +24,7 @@ class TestDnsConfigChangeManagerClient
     manager_remote->RequestNotifications(receiver_.BindNewPipeAndPassRemote());
   }
 
-  void OnSystemDnsConfigChanged() override {
+  void OnDnsConfigChanged() override {
     num_notifications_++;
     if (num_notifications_ >= num_notifications_expected_)
       run_loop_.Quit();

services/network/public/mojom/host_resolver.mojom

@@ -294,9 +294,10 @@ interface HostResolver {
 // A client interface that subscribes to DNS config change events from
 // DnsConfigChangeManager.
 interface DnsConfigChangeManagerClient {
-  // Notifies that a potential change has been detected in the DNS settings of
-  // the system that may affect results of host resolution.
-  OnSystemDnsConfigChanged();
+  // Notifies that a potential change has been detected in the DNS configuration
+  // that may affect results of host resolution. May be a change in system DNS
+  // settings or effective changes added on top by Chrome net code.
+  OnDnsConfigChanged();
 };
 
 // An interface that broadcasts DNS config change events.