Commit 0500029d authored by Joe DeBlasio's avatar Joe DeBlasio Committed by Commit Bot

[Safety Tips] s/NoActionTaken/NoAction in histogram names.

Safety Tips have always recorded histogram names based on NoAction, but
histograms.xml has had NoActionTaken. That made it look like
NoActionTaken just never happened. I now know better. This change
lets us see the existing data from the dashboard. :-(

The code in question is at:
https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/reputation/reputation_web_contents_observer.cc;l=69?q=Security.SafetyTips.Interaction&ss=chromium

Change-Id: I2cc79ffaf70e962b24f34635e698db3aa145083a
Fixed: 1137615
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466512
Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816495}
parent b9454e04
...@@ -16140,7 +16140,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -16140,7 +16140,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<affected-histogram name="Security.SafetyTips.OpenTime.DismissWithEsc"/> <affected-histogram name="Security.SafetyTips.OpenTime.DismissWithEsc"/>
<affected-histogram name="Security.SafetyTips.OpenTime.DismissWithIgnore"/> <affected-histogram name="Security.SafetyTips.OpenTime.DismissWithIgnore"/>
<affected-histogram name="Security.SafetyTips.OpenTime.LeaveSite"/> <affected-histogram name="Security.SafetyTips.OpenTime.LeaveSite"/>
<affected-histogram name="Security.SafetyTips.OpenTime.NoActionTaken"/> <affected-histogram name="Security.SafetyTips.OpenTime.NoAction"/>
<affected-histogram name="Security.SafetyTips.PageInfo.Action"/> <affected-histogram name="Security.SafetyTips.PageInfo.Action"/>
<affected-histogram name="Security.SiteEngagement"/> <affected-histogram name="Security.SiteEngagement"/>
<affected-histogram name="Security.SiteEngagementDelta"/> <affected-histogram name="Security.SiteEngagementDelta"/>
......
...@@ -320,7 +320,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -320,7 +320,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</summary> </summary>
</histogram> </histogram>
<histogram name="Security.SafetyTips.OpenTime.NoActionTaken" units="ms" <histogram name="Security.SafetyTips.OpenTime.NoAction" units="ms"
expires_after="M90"> expires_after="M90">
<owner>jdeblasio@chromium.org</owner> <owner>jdeblasio@chromium.org</owner>
<owner>estark@chromium.org</owner> <owner>estark@chromium.org</owner>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment