Exposes <hr> elements that do not have an ARIA label.

BUG=384723 R=dmazzoni@chromium.org TESTED=browser tests, using Jaws Review URL: https://codereview.chromium.org/1695673004 Cr-Commit-Position: refs/heads/master@{#376055}

Exposes <hr> elements that do not have an ARIA label.
BUG=384723 R=dmazzoni@chromium.org TESTED=browser tests, using Jaws Review URL: https://codereview.chromium.org/1695673004 Cr-Commit-Position: refs/heads/master@{#376055}
05422fee · nektar · Commit bot · c789639d · 05422fee · 05422fee
Commit 05422fee authored Feb 17, 2016 by nektar Committed by Commit bot Feb 18, 2016
5 changed files
--- a/content/test/data/accessibility/html/hr-expected-android.txt
+++ b/content/test/data/accessibility/html/hr-expected-android.txt
 android.webkit.WebView focusable focused scrollable
-++android.view.View clickable name='Before'
++android.view.View clickable name='Before.'
 ++android.view.View role_description='splitter' clickable name='Dividing line'
-++android.view.View clickable name='After'
++android.view.View clickable name='Middle.'
\ No newline at end of file
++android.view.View role_description='splitter'
++android.view.View clickable name='After.'
--- a/content/test/data/accessibility/html/hr-expected-mac.txt
+++ b/content/test/data/accessibility/html/hr-expected-mac.txt
 AXWebArea AXRoleDescription='HTML content'
 ++AXGroup AXRoleDescription='group'
-++++AXStaticText AXRoleDescription='text' AXValue='Before'
++++AXStaticText AXRoleDescription='text' AXValue='Before.'
 ++AXSplitter AXRoleDescription='splitter' AXDescription='Dividing line'
 ++AXGroup AXRoleDescription='group'
-++++AXStaticText AXRoleDescription='text' AXValue='After'
++++AXStaticText AXRoleDescription='text' AXValue='Middle.'
++AXSplitter AXRoleDescription='splitter'
++AXGroup AXRoleDescription='group'
++++AXStaticText AXRoleDescription='text' AXValue='After.'
--- a/content/test/data/accessibility/html/hr-expected-win.txt
+++ b/content/test/data/accessibility/html/hr-expected-win.txt
 ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE
-++IA2_ROLE_SECTION
++IA2_ROLE_PARAGRAPH
-++++ROLE_SYSTEM_STATICTEXT name='Before'
++++ROLE_SYSTEM_STATICTEXT name='Before.'
 ++ROLE_SYSTEM_SEPARATOR name='Dividing line'
-++IA2_ROLE_SECTION
++IA2_ROLE_PARAGRAPH
-++++ROLE_SYSTEM_STATICTEXT name='After'
++++ROLE_SYSTEM_STATICTEXT name='Middle.'
++ROLE_SYSTEM_SEPARATOR
++IA2_ROLE_PARAGRAPH
++++ROLE_SYSTEM_STATICTEXT name='After.'
--- a/content/test/data/accessibility/html/hr.html
+++ b/content/test/data/accessibility/html/hr.html
@@ -5,8 +5,10 @@
 <!DOCTYPE html>
 <html>
 <body>
-Before
+<p>Before.</p>
 <hr aria-label="Dividing line">
-After
+<p>Middle.</p>
+<hr>
+<p>After.</p>
 </body>
 </html>
--- a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
@@ -670,6 +670,9 @@ bool AXLayoutObject::computeAccessibilityIsIgnored(IgnoredReasons* ignoredReason
    if (roleValue() == DetailsRole)
        return false;
+    if (roleValue() == MarkRole)
+        return false;
    if (roleValue() == MathRole)
        return false;
@@ -679,10 +682,10 @@ bool AXLayoutObject::computeAccessibilityIsIgnored(IgnoredReasons* ignoredReason
    if (roleValue() == RubyRole)
        return false;
-    if (roleValue() == TimeRole)
+    if (roleValue() == SplitterRole)
        return false;
-    if (roleValue() == MarkRole)
+    if (roleValue() == TimeRole)
        return false;
    // if this element has aria attributes on it, it should not be ignored.