Commit 0543b6d9 authored by Peter K. Lee's avatar Peter K. Lee Committed by Commit Bot

Removes 2-param CreateViewController from Provider API (5/5)

Finally, the last step of removing from UserFeedback Provider API.
Submit this after all other downstream CLs have been submitted.

Bug: 847329
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1c8fb9fdf5e9b3f65e959577a563e9f7311d93e6
Reviewed-on: https://chromium-review.googlesource.com/1132542Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575006}
parent fdfd912e
...@@ -45,12 +45,6 @@ class UserFeedbackProvider { ...@@ -45,12 +45,6 @@ class UserFeedbackProvider {
// Returns view controller to present to the user to collect their feedback. // Returns view controller to present to the user to collect their feedback.
virtual UIViewController* CreateViewController( virtual UIViewController* CreateViewController(
id<UserFeedbackDataSource> data_source); id<UserFeedbackDataSource> data_source);
// Returns view controller to present to the user to collect their feedback.
// DEPRECATED: Use CreateViewController with a single parameter of
// |data_source| instead.
virtual UIViewController* CreateViewController(
id<UserFeedbackDataSource> dataSource,
id<ApplicationCommands> dispatcher);
// Uploads collected feedback reports. // Uploads collected feedback reports.
virtual void Synchronize(); virtual void Synchronize();
......
...@@ -21,10 +21,4 @@ UIViewController* UserFeedbackProvider::CreateViewController( ...@@ -21,10 +21,4 @@ UIViewController* UserFeedbackProvider::CreateViewController(
return nil; return nil;
} }
UIViewController* UserFeedbackProvider::CreateViewController(
id<UserFeedbackDataSource> dataSource,
id<ApplicationCommands> dispatcher) {
return nil;
}
void UserFeedbackProvider::Synchronize() {} void UserFeedbackProvider::Synchronize() {}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment