Commit 0585519c authored by mpearson's avatar mpearson Committed by Commit bot

Revert of Fix the mobile emulator to use the correct device scale when...

Revert of Fix the mobile emulator to use the correct device scale when disabled. (patchset #1 id:1 of https://codereview.chromium.org/2168313002/ )

Reason for revert:
Likely cause of webkit_tests unexpected_failures
inspector/screen-orientation-override.html

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux/67873/layout-test-results/results.html

Failure appeared on many bots:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux/builds/67873
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/15157
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10/builds/21002
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11/builds/7468
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/12746

and it seems related (change to devtools, failure in "inspector")

Original issue's description:
> Fix the mobile emulator to use the correct device scale when disabled.
>
> The mobile emulator was triggering a layout before it had reapplied the
> original viewport parameters when it was being disabled, which with
> use-zoom-for-dsf enabled was causing the wrong viewport size to be given
> to various components, like plugins and scrollbars.
>
> BUG=628501,628185
>
> Committed: https://crrev.com/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f
> Cr-Commit-Position: refs/heads/master@{#407294}

TBR=dgozman@chromium.org,alph@chromium.org,bsep@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=628501,628185

Review-Url: https://codereview.chromium.org/2174493004
Cr-Commit-Position: refs/heads/master@{#407314}
parent a376ed55
......@@ -25,10 +25,10 @@ RenderWidgetScreenMetricsEmulator::RenderWidgetScreenMetricsEmulator(
}
RenderWidgetScreenMetricsEmulator::~RenderWidgetScreenMetricsEmulator() {
delegate_->Resize(original_resize_params_);
delegate_->SetScreenMetricsEmulationParameters(false, emulation_params_);
delegate_->SetScreenRects(original_view_screen_rect_,
original_window_screen_rect_);
delegate_->Resize(original_resize_params_);
}
void RenderWidgetScreenMetricsEmulator::ChangeEmulationParams(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment