Commit 05a54caa authored by Rakina Zata Amni's avatar Rakina Zata Amni Committed by Chromium LUCI CQ

Add nullcheck in MimeHandlerViewEmbedder::DidFinishNavigation

The RFH accessed in a DCHECK might be null if the navigation never reached the ReadyToCommitNavigation state.

Bug: 1133115
Change-Id: I57472efb15d4acb375c5a6980ca5b661bb08f53a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569637
Auto-Submit: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: default avatarJames MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833274}
parent f9a2e454
...@@ -106,8 +106,10 @@ void MimeHandlerViewEmbedder::ReadyToCommitNavigation( ...@@ -106,8 +106,10 @@ void MimeHandlerViewEmbedder::ReadyToCommitNavigation(
void MimeHandlerViewEmbedder::DidFinishNavigation( void MimeHandlerViewEmbedder::DidFinishNavigation(
content::NavigationHandle* handle) { content::NavigationHandle* handle) {
if (frame_tree_node_id_ != handle->GetFrameTreeNodeId()) if (!render_frame_host_ ||
frame_tree_node_id_ != handle->GetFrameTreeNodeId()) {
return; return;
}
// We should've deleted the MimeHandlerViewEmbedder at this point if the frame // We should've deleted the MimeHandlerViewEmbedder at this point if the frame
// is sandboxed. // is sandboxed.
DCHECK(!render_frame_host_->IsSandboxed( DCHECK(!render_frame_host_->IsSandboxed(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment