Commit 05ab21f2 authored by achuith@chromium.org's avatar achuith@chromium.org

Fixes for browser finder unittests on cros.

These tests don't succeed because of desktop_browser_finder.CanFindAvailableBrowsers:
https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py&q=CanFindAvailableBrowsers&l=84

BUG=331940
TEST=manual

Review URL: https://codereview.chromium.org/135063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244424 0039d316-1c4b-4281-b951-d872f2087c98
parent d2e91631
...@@ -5,7 +5,6 @@ import unittest ...@@ -5,7 +5,6 @@ import unittest
from telemetry.core import browser_options from telemetry.core import browser_options
from telemetry.core.backends.chrome import desktop_browser_finder from telemetry.core.backends.chrome import desktop_browser_finder
from telemetry.unittest import DisabledTestOnCrOS
from telemetry.unittest import system_stub from telemetry.unittest import system_stub
# This file verifies the logic for finding a browser instance on all platforms # This file verifies the logic for finding a browser instance on all platforms
...@@ -35,55 +34,74 @@ class FindTestBase(unittest.TestCase): ...@@ -35,55 +34,74 @@ class FindTestBase(unittest.TestCase):
browsers = self.DoFindAll() browsers = self.DoFindAll()
return [b.browser_type for b in browsers] return [b.browser_type for b in browsers]
def CanFindAvailableBrowsers(self):
return desktop_browser_finder.CanFindAvailableBrowsers()
def has_type(array, browser_type): def has_type(array, browser_type):
return len([x for x in array if x.browser_type == browser_type]) != 0 return len([x for x in array if x.browser_type == browser_type]) != 0
class FindSystemTest(FindTestBase): class FindSystemTest(FindTestBase):
def setUp(self): def setUp(self):
super(FindSystemTest, self).setUp() super(FindSystemTest, self).setUp()
self._stubs.sys.platform = 'win32' self._stubs.sys.platform = 'win32'
@DisabledTestOnCrOS
def testFindProgramFiles(self): def testFindProgramFiles(self):
if not self.CanFindAvailableBrowsers():
return
self._files.append( self._files.append(
'C:\\Program Files\\Google\\Chrome\\Application\\chrome.exe') 'C:\\Program Files\\Google\\Chrome\\Application\\chrome.exe')
self._stubs.os.program_files = 'C:\\Program Files' self._stubs.os.program_files = 'C:\\Program Files'
self.assertTrue('system' in self.DoFindAllTypes()) self.assertTrue('system' in self.DoFindAllTypes())
@DisabledTestOnCrOS
def testFindProgramFilesX86(self): def testFindProgramFilesX86(self):
if not self.CanFindAvailableBrowsers():
return
self._files.append( self._files.append(
'C:\\Program Files(x86)\\Google\\Chrome\\Application\\chrome.exe') 'C:\\Program Files(x86)\\Google\\Chrome\\Application\\chrome.exe')
self._stubs.os.program_files_x86 = 'C:\\Program Files(x86)' self._stubs.os.program_files_x86 = 'C:\\Program Files(x86)'
self.assertTrue('system' in self.DoFindAllTypes()) self.assertTrue('system' in self.DoFindAllTypes())
@DisabledTestOnCrOS
def testFindLocalAppData(self): def testFindLocalAppData(self):
if not self.CanFindAvailableBrowsers():
return
self._files.append( self._files.append(
'C:\\Local App Data\\Google\\Chrome\\Application\\chrome.exe') 'C:\\Local App Data\\Google\\Chrome\\Application\\chrome.exe')
self._stubs.os.local_app_data = 'C:\\Local App Data' self._stubs.os.local_app_data = 'C:\\Local App Data'
self.assertTrue('system' in self.DoFindAllTypes()) self.assertTrue('system' in self.DoFindAllTypes())
class FindLocalBuildsTest(FindTestBase): class FindLocalBuildsTest(FindTestBase):
def setUp(self): def setUp(self):
super(FindLocalBuildsTest, self).setUp() super(FindLocalBuildsTest, self).setUp()
self._stubs.sys.platform = 'win32' self._stubs.sys.platform = 'win32'
@DisabledTestOnCrOS
def testFindBuild(self): def testFindBuild(self):
if not self.CanFindAvailableBrowsers():
return
self._files.append('..\\..\\..\\build\\Release\\chrome.exe') self._files.append('..\\..\\..\\build\\Release\\chrome.exe')
self.assertTrue('release' in self.DoFindAllTypes()) self.assertTrue('release' in self.DoFindAllTypes())
@DisabledTestOnCrOS
def testFindOut(self): def testFindOut(self):
if not self.CanFindAvailableBrowsers():
return
self._files.append('..\\..\\..\\out\\Release\\chrome.exe') self._files.append('..\\..\\..\\out\\Release\\chrome.exe')
self.assertTrue('release' in self.DoFindAllTypes()) self.assertTrue('release' in self.DoFindAllTypes())
@DisabledTestOnCrOS
def testFindXcodebuild(self): def testFindXcodebuild(self):
if not self.CanFindAvailableBrowsers():
return
self._files.append('..\\..\\..\\xcodebuild\\Release\\chrome.exe') self._files.append('..\\..\\..\\xcodebuild\\Release\\chrome.exe')
self.assertTrue('release' in self.DoFindAllTypes()) self.assertTrue('release' in self.DoFindAllTypes())
class OSXFindTest(FindTestBase): class OSXFindTest(FindTestBase):
def setUp(self): def setUp(self):
super(OSXFindTest, self).setUp() super(OSXFindTest, self).setUp()
...@@ -101,8 +119,10 @@ class OSXFindTest(FindTestBase): ...@@ -101,8 +119,10 @@ class OSXFindTest(FindTestBase):
self._files.append( self._files.append(
'../../../out/Debug/Content Shell.app/Contents/MacOS/Content Shell') '../../../out/Debug/Content Shell.app/Contents/MacOS/Content Shell')
@DisabledTestOnCrOS
def testFindAll(self): def testFindAll(self):
if not self.CanFindAvailableBrowsers():
return
types = self.DoFindAllTypes() types = self.DoFindAllTypes()
self.assertEquals( self.assertEquals(
set(types), set(types),
...@@ -130,21 +150,27 @@ class LinuxFindTest(FindTestBase): ...@@ -130,21 +150,27 @@ class LinuxFindTest(FindTestBase):
raise OSError('Not found') raise OSError('Not found')
self._stubs.subprocess.call = call_hook self._stubs.subprocess.call = call_hook
@DisabledTestOnCrOS
def testFindAllWithExact(self): def testFindAllWithExact(self):
if not self.CanFindAvailableBrowsers():
return
types = self.DoFindAllTypes() types = self.DoFindAllTypes()
self.assertEquals( self.assertEquals(
set(types), set(types),
set(['debug', 'release', set(['debug', 'release',
'content-shell-debug', 'content-shell-release'])) 'content-shell-debug', 'content-shell-release']))
@DisabledTestOnCrOS
def testFindWithProvidedExecutable(self): def testFindWithProvidedExecutable(self):
if not self.CanFindAvailableBrowsers():
return
self._finder_options.browser_executable = '/foo/chrome' self._finder_options.browser_executable = '/foo/chrome'
self.assertTrue('exact' in self.DoFindAllTypes()) self.assertTrue('exact' in self.DoFindAllTypes())
@DisabledTestOnCrOS
def testFindUsingDefaults(self): def testFindUsingDefaults(self):
if not self.CanFindAvailableBrowsers():
return
self.has_google_chrome_on_path = True self.has_google_chrome_on_path = True
self.assertTrue('release' in self.DoFindAllTypes()) self.assertTrue('release' in self.DoFindAllTypes())
...@@ -157,8 +183,10 @@ class LinuxFindTest(FindTestBase): ...@@ -157,8 +183,10 @@ class LinuxFindTest(FindTestBase):
self.assertEquals(['content-shell-debug', 'content-shell-release'], self.assertEquals(['content-shell-debug', 'content-shell-release'],
self.DoFindAllTypes()) self.DoFindAllTypes())
@DisabledTestOnCrOS
def testFindUsingRelease(self): def testFindUsingRelease(self):
if not self.CanFindAvailableBrowsers():
return
self.assertTrue('release' in self.DoFindAllTypes()) self.assertTrue('release' in self.DoFindAllTypes())
...@@ -178,16 +206,20 @@ class WinFindTest(FindTestBase): ...@@ -178,16 +206,20 @@ class WinFindTest(FindTestBase):
self._files.append(self._stubs.os.local_app_data + '\\' + self._files.append(self._stubs.os.local_app_data + '\\' +
'Google\\Chrome SxS\\Application\\chrome.exe') 'Google\\Chrome SxS\\Application\\chrome.exe')
@DisabledTestOnCrOS
def testFindAllGivenDefaults(self): def testFindAllGivenDefaults(self):
if not self.CanFindAvailableBrowsers():
return
types = self.DoFindAllTypes() types = self.DoFindAllTypes()
self.assertEquals(set(types), self.assertEquals(set(types),
set(['debug', 'release', set(['debug', 'release',
'content-shell-debug', 'content-shell-release', 'content-shell-debug', 'content-shell-release',
'system', 'canary'])) 'system', 'canary']))
@DisabledTestOnCrOS
def testFindAllWithExact(self): def testFindAllWithExact(self):
if not self.CanFindAvailableBrowsers():
return
self._finder_options.browser_executable = 'c:\\tmp\\chrome.exe' self._finder_options.browser_executable = 'c:\\tmp\\chrome.exe'
types = self.DoFindAllTypes() types = self.DoFindAllTypes()
self.assertEquals( self.assertEquals(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment