[WebLayer] Create and use ExternalNavigationParams

This CL takes a prepapatory step to WebLayer sharing Chrome's
ExternalNavigationHandler for launching external intents by creating
and populating the ExternalNavigationParams struct that gets passed
to the former class. I adapted the building of ExternalNavigationParams
in //chrome's
InterceptNavigationDelegateImpl.java:buildExternalNavigationParams() to
//weblayer, leaving notes in the code where we might need to refine
the calculation of some arguments over time.

This CL also changes //weblayer's ExternalNavigationHandler to take in
the params just so that the constructed object is used. There is no
behavioral change.

Bug: 1031465
Change-Id: If7135fcbfc9d369f2683208fde12725925156736
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100974Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751051}

weblayer/BUILD.gn

@@ -350,6 +350,7 @@ source_set("weblayer_lib_base") {
       "//components/embedder_support/android:util",
       "//components/embedder_support/android:web_contents_delegate",
       "//components/embedder_support/android/metrics",
+      "//components/external_intents/android",
       "//components/javascript_dialogs",
       "//components/metrics",
       "//components/minidump_uploader",

weblayer/browser/java/BUILD.gn

@@ -91,6 +91,7 @@ android_library("java") {
     "//components/embedder_support/android:util_java",
     "//components/embedder_support/android:web_contents_delegate_java",
     "//components/embedder_support/android/metrics:java",
+    "//components/external_intents/android:java",
     "//components/find_in_page/android:java",
     "//components/javascript_dialogs/android:java",
     "//components/metrics:metrics_java",

weblayer/browser/java/DEPS

 include_rules = [
   "+components/browser_ui/util/android",
   "+components/crash/android/java",
+  "+components/external_intents",
   "+components/minidump_uploader",
   "+services/device/public/java/src/org/chromium/device/geolocation",
 ]

weblayer/browser/java/org/chromium/weblayer_private/ExternalNavigationHandler.java

@@ -12,6 +12,7 @@ import android.provider.Browser;
 import org.chromium.base.Log;
 import org.chromium.components.embedder_support.util.UrlConstants;
 import org.chromium.components.embedder_support.util.UrlUtilities;
+import org.chromium.components.external_intents.ExternalNavigationParams;
 import org.chromium.content_public.common.ContentUrlConstants;
 import org.chromium.ui.base.PageTransition;
 
@@ -57,8 +58,13 @@ public class ExternalNavigationHandler {
         return true;
     }
 
-    static boolean shouldOverrideUrlLoading(TabImpl tab, String url, boolean hasUserGesture,
-            boolean isRedirect, boolean isMainFrame, int pageTransition) {
+    static boolean shouldOverrideUrlLoading(TabImpl tab, ExternalNavigationParams params) {
+        String url = params.getUrl();
+        boolean hasUserGesture = params.hasUserGesture();
+        boolean isRedirect = params.isRedirect();
+        boolean isMainFrame = params.isMainFrame();
+        int pageTransition = params.getPageTransition();
+
         if (UrlUtilities.isAcceptedScheme(url)) return false;
 
         // A back-forward navigation should never trigger an intent.

weblayer/browser/java/org/chromium/weblayer_private/InterceptNavigationDelegateImpl.java

@@ -5,6 +5,7 @@
 package org.chromium.weblayer_private;
 
 import org.chromium.base.annotations.NativeMethods;
+import org.chromium.components.external_intents.ExternalNavigationParams;
 import org.chromium.components.navigation_interception.InterceptNavigationDelegate;
 import org.chromium.components.navigation_interception.NavigationParams;
 import org.chromium.content_public.browser.WebContents;
@@ -25,11 +26,46 @@ public class InterceptNavigationDelegateImpl implements InterceptNavigationDeleg
                 this, mTab.getWebContents());
     }
 
+    /**
+     * Returns ExternalNavigationParams.Builder to generate ExternalNavigationParams for
+     * ExternalNavigationHandler#shouldOverrideUrlLoading().
+     */
+    private ExternalNavigationParams.Builder buildExternalNavigationParams(
+            NavigationParams navigationParams, boolean shouldCloseTab) {
+        return new ExternalNavigationParams
+                .Builder(navigationParams.url, mTab.getProfile().isIncognito(),
+                        navigationParams.referrer, navigationParams.pageTransitionType,
+                        navigationParams.isRedirect)
+                .setApplicationMustBeInForeground(true)
+                // NOTE: ExternalNavigationHandler.java supports the redirect handler being
+                // null, although WebLayer will likely eventually want one.
+                .setRedirectHandler(null)
+                .setOpenInNewTab(shouldCloseTab)
+                // TODO(crbug.com/1031465): See whether this needs to become more refined
+                // (cf. //chrome's setting of this field in its version of this method).
+                .setIsBackgroundTabNavigation(!mTab.isVisible())
+                .setIsMainFrame(navigationParams.isMainFrame)
+                .setHasUserGesture(navigationParams.hasUserGesture)
+                .setShouldCloseContentsOnOverrideUrlLoadingAndLaunchIntent(
+                        shouldCloseTab && navigationParams.isMainFrame);
+    }
+
+    private boolean shouldCloseContentsOnOverrideUrlLoadingAndLaunchIntent() {
+        if (mTab.getWebContents() == null) return false;
+
+        if (!mTab.getWebContents().getNavigationController().canGoToOffset(0)) return true;
+
+        // TODO(crbug.com/1031465): Adapt the TabRedirectHandler-dependent check that //chrome's
+        // InterceptNavigationDelegateImpl.java does in its version of this method?
+        return false;
+    }
+
     @Override
     public boolean shouldIgnoreNavigation(NavigationParams navigationParams) {
-        return ExternalNavigationHandler.shouldOverrideUrlLoading(mTab, navigationParams.url,
-                navigationParams.hasUserGesture, navigationParams.isRedirect,
-                navigationParams.isMainFrame, navigationParams.pageTransitionType);
+        boolean shouldCloseTab = shouldCloseContentsOnOverrideUrlLoadingAndLaunchIntent();
+        ExternalNavigationParams params =
+                buildExternalNavigationParams(navigationParams, shouldCloseTab).build();
+        return ExternalNavigationHandler.shouldOverrideUrlLoading(mTab, params);
     }
 
     @NativeMethods

weblayer/browser/java/org/chromium/weblayer_private/TabImpl.java

@@ -257,8 +257,15 @@ public final class TabImpl extends ITab.Stub {
         TabImplJni.get().setTopControlsContainerView(mNativeTab, TabImpl.this, 0);
     }
 
+    /**
+     * Returns whether this Tab is visible.
+     */
+    public boolean isVisible() {
+        return (mBrowser.getActiveTab() == this && mBrowser.isStarted());
+    }
+
     private void updateWebContentsVisibility() {
-        boolean visibleNow = mBrowser.getActiveTab() == this && mBrowser.isStarted();
+        boolean visibleNow = isVisible();
         boolean webContentsVisible = mWebContents.getVisibility() == Visibility.VISIBLE;
         if (visibleNow) {
             if (!webContentsVisible) mWebContents.onShow();