Commit 05b1e211 authored by Peter Kasting's avatar Peter Kasting Committed by Commit Bot

Revert "WebApps: Fix PWA initial positions in certain configs"

This reverts commit fb30c93b.

Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1066610

Original change's description:
> WebApps: Fix PWA initial positions in certain configs
> 
> Similar to Bug: 783199, when user have two monitors that set to
> different scales, PWA may relaunch off the screen.
> This change does a similar fix for PWA as the original change did
> for devtools.
> 
> Bug: 1046481
> Change-Id: I63230b01c59c5f277298c5bc5e51c8703cc6f54a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074799
> Commit-Queue: Junyi Xiao <juxiao@microsoft.com>
> Commit-Queue: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#755007}

TBR=pkasting@chromium.org,mjackson@microsoft.com,lomitch@microsoft.com,juxiao@microsoft.com

Change-Id: I8bfbcdb7d1c36492bb116b45464d5e09ca13e01a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1046481
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131009Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755072}
parent b0ea76f9
......@@ -77,8 +77,7 @@ void BrowserFrame::InitBrowserFrame() {
params.name = "BrowserFrame";
params.delegate = browser_view_;
if (browser_view_->browser()->is_type_normal() ||
browser_view_->browser()->is_type_devtools() ||
browser_view_->browser()->is_type_app()) {
browser_view_->browser()->is_type_devtools()) {
// Typed panel/popup can only return a size once the widget has been
// created.
// DevTools counts as a popup, but DevToolsWindow::CreateDevToolsBrowser
......
......@@ -7,11 +7,7 @@
#include "base/macros.h"
#include "build/build_config.h"
#include "chrome/browser/devtools/devtools_window_testing.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/views/chrome_views_delegate.h"
#include "chrome/browser/ui/web_applications/test/web_app_browsertest_util.h"
#include "chrome/common/web_application_info.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/browser/invalidate_type.h"
......@@ -44,16 +40,3 @@ IN_PROC_BROWSER_TEST_F(BrowserFrameTest, DevToolsHasBoundsOnOpen) {
DevToolsWindowTesting::OpenDevToolsWindowSync(browser(), false);
DevToolsWindowTesting::CloseDevToolsWindowSync(devtools_);
}
// Verifies that the web app is loaded with initial bounds.
IN_PROC_BROWSER_TEST_F(BrowserFrameTest, WebAppsHasBoundsOnOpen) {
auto web_app_info = std::make_unique<WebApplicationInfo>();
web_app_info->app_url = GURL("http://example.org/");
web_app::AppId app_id =
web_app::InstallWebApp(browser()->profile(), std::move(web_app_info));
Browser* app_browser =
web_app::LaunchWebAppBrowser(browser()->profile(), app_id);
ASSERT_TRUE(app_browser->is_type_app());
app_browser->window()->Close();
}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment