Commit 05d339e4 authored by Stepan Khapugin's avatar Stepan Khapugin Committed by Commit Bot

[multiball] Remove unused argument.

Removes unused method argument in app state.

Bug: none
Change-Id: I126ed9d24407311b2bae745ec8af2eec791f10b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386803
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803556}
parent 6e670242
...@@ -123,8 +123,7 @@ initWithBrowserLauncher:(id<BrowserLauncher>)browserLauncher ...@@ -123,8 +123,7 @@ initWithBrowserLauncher:(id<BrowserLauncher>)browserLauncher
// Starts the browser to foreground if needed. // Starts the browser to foreground if needed.
- (void)applicationWillEnterForeground:(UIApplication*)application - (void)applicationWillEnterForeground:(UIApplication*)application
metricsMediator:(MetricsMediator*)metricsMediator metricsMediator:(MetricsMediator*)metricsMediator
memoryHelper:(MemoryWarningHelper*)memoryHelper memoryHelper:(MemoryWarningHelper*)memoryHelper;
tabOpener:(id<TabOpening>)tabOpener;
// Sets the return value for -didFinishLaunchingWithOptions that determines if // Sets the return value for -didFinishLaunchingWithOptions that determines if
// UIKit should make followup delegate calls such as // UIKit should make followup delegate calls such as
......
...@@ -325,8 +325,7 @@ initWithBrowserLauncher:(id<BrowserLauncher>)browserLauncher ...@@ -325,8 +325,7 @@ initWithBrowserLauncher:(id<BrowserLauncher>)browserLauncher
- (void)applicationWillEnterForeground:(UIApplication*)application - (void)applicationWillEnterForeground:(UIApplication*)application
metricsMediator:(MetricsMediator*)metricsMediator metricsMediator:(MetricsMediator*)metricsMediator
memoryHelper:(MemoryWarningHelper*)memoryHelper memoryHelper:(MemoryWarningHelper*)memoryHelper {
tabOpener:(id<TabOpening>)tabOpener {
if ([_browserLauncher browserInitializationStage] < if ([_browserLauncher browserInitializationStage] <
INITIALIZATION_STAGE_FOREGROUND) { INITIALIZATION_STAGE_FOREGROUND) {
// The application has been launched in background and the initialization // The application has been launched in background and the initialization
......
...@@ -294,8 +294,7 @@ class AppStateTest : public BlockCleanupTest { ...@@ -294,8 +294,7 @@ class AppStateTest : public BlockCleanupTest {
[appState applicationWillEnterForeground:application [appState applicationWillEnterForeground:application
metricsMediator:metricsMediator metricsMediator:metricsMediator
memoryHelper:memoryHelper memoryHelper:memoryHelper];
tabOpener:tabOpener];
initializeIncognitoBlocker(window); initializeIncognitoBlocker(window);
...@@ -802,8 +801,7 @@ TEST_F(AppStateTest, applicationWillEnterForeground) { ...@@ -802,8 +801,7 @@ TEST_F(AppStateTest, applicationWillEnterForeground) {
// Actions. // Actions.
[getAppStateWithMock() applicationWillEnterForeground:application [getAppStateWithMock() applicationWillEnterForeground:application
metricsMediator:metricsMediator metricsMediator:metricsMediator
memoryHelper:memoryHelper memoryHelper:memoryHelper];
tabOpener:tabOpener];
// Tests. // Tests.
EXPECT_OCMOCK_VERIFY(metricsMediator); EXPECT_OCMOCK_VERIFY(metricsMediator);
...@@ -822,7 +820,6 @@ TEST_F(AppStateTest, applicationWillEnterForegroundFromBackground) { ...@@ -822,7 +820,6 @@ TEST_F(AppStateTest, applicationWillEnterForegroundFromBackground) {
id application = [OCMockObject mockForClass:[UIApplication class]]; id application = [OCMockObject mockForClass:[UIApplication class]];
id metricsMediator = [OCMockObject mockForClass:[MetricsMediator class]]; id metricsMediator = [OCMockObject mockForClass:[MetricsMediator class]];
id memoryHelper = [OCMockObject mockForClass:[MemoryWarningHelper class]]; id memoryHelper = [OCMockObject mockForClass:[MemoryWarningHelper class]];
id tabOpener = [OCMockObject mockForProtocol:@protocol(TabOpening)];
BrowserInitializationStageType stage = INITIALIZATION_STAGE_BACKGROUND; BrowserInitializationStageType stage = INITIALIZATION_STAGE_BACKGROUND;
[[[getBrowserLauncherMock() stub] andReturnValue:@(stage)] [[[getBrowserLauncherMock() stub] andReturnValue:@(stage)]
...@@ -838,8 +835,7 @@ TEST_F(AppStateTest, applicationWillEnterForegroundFromBackground) { ...@@ -838,8 +835,7 @@ TEST_F(AppStateTest, applicationWillEnterForegroundFromBackground) {
// Actions. // Actions.
[getAppStateWithMock() applicationWillEnterForeground:application [getAppStateWithMock() applicationWillEnterForeground:application
metricsMediator:metricsMediator metricsMediator:metricsMediator
memoryHelper:memoryHelper memoryHelper:memoryHelper];
tabOpener:tabOpener];
// Tests. // Tests.
EXPECT_OCMOCK_VERIFY(getBrowserLauncherMock()); EXPECT_OCMOCK_VERIFY(getBrowserLauncherMock());
...@@ -857,7 +853,6 @@ TEST_F(AppStateTest, ...@@ -857,7 +853,6 @@ TEST_F(AppStateTest,
id application = [OCMockObject mockForClass:[UIApplication class]]; id application = [OCMockObject mockForClass:[UIApplication class]];
id metricsMediator = [OCMockObject mockForClass:[MetricsMediator class]]; id metricsMediator = [OCMockObject mockForClass:[MetricsMediator class]];
id memoryHelper = [OCMockObject mockForClass:[MemoryWarningHelper class]]; id memoryHelper = [OCMockObject mockForClass:[MemoryWarningHelper class]];
id tabOpener = [OCMockObject mockForProtocol:@protocol(TabOpening)];
id window = getWindowMock(); id window = getWindowMock();
...@@ -882,8 +877,7 @@ TEST_F(AppStateTest, ...@@ -882,8 +877,7 @@ TEST_F(AppStateTest,
// Actions. // Actions.
[getAppStateWithMock() applicationWillEnterForeground:application [getAppStateWithMock() applicationWillEnterForeground:application
metricsMediator:metricsMediator metricsMediator:metricsMediator
memoryHelper:memoryHelper memoryHelper:memoryHelper];
tabOpener:tabOpener];
// Tests. // Tests.
EXPECT_OCMOCK_VERIFY(window); EXPECT_OCMOCK_VERIFY(window);
......
...@@ -206,8 +206,7 @@ ...@@ -206,8 +206,7 @@
[_appState applicationWillEnterForeground:application [_appState applicationWillEnterForeground:application
metricsMediator:_metricsMediator metricsMediator:_metricsMediator
memoryHelper:_memoryHelper memoryHelper:_memoryHelper];
tabOpener:_tabOpener];
} }
- (void)applicationWillTerminate:(UIApplication*)application { - (void)applicationWillTerminate:(UIApplication*)application {
...@@ -275,8 +274,7 @@ ...@@ -275,8 +274,7 @@
if (self.foregroundSceneCount == 0) { if (self.foregroundSceneCount == 0) {
[_appState applicationWillEnterForeground:UIApplication.sharedApplication [_appState applicationWillEnterForeground:UIApplication.sharedApplication
metricsMediator:_metricsMediator metricsMediator:_metricsMediator
memoryHelper:_memoryHelper memoryHelper:_memoryHelper];
tabOpener:_tabOpener];
} }
} }
} }
...@@ -296,8 +294,7 @@ ...@@ -296,8 +294,7 @@
if (@available(iOS 13, *)) { if (@available(iOS 13, *)) {
[_appState applicationWillEnterForeground:UIApplication.sharedApplication [_appState applicationWillEnterForeground:UIApplication.sharedApplication
metricsMediator:_metricsMediator metricsMediator:_metricsMediator
memoryHelper:_memoryHelper memoryHelper:_memoryHelper];
tabOpener:_tabOpener];
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment