Commit 05f1d46e authored by Mirko Bonadei's avatar Mirko Bonadei Committed by Commit Bot

Stop exposing libjingle_xmpp:rtc_task_runner from webrtc_overrides.

There is no reason to depend on libjingle_xmpp:rtc_task_runner from
//third_party/webrtc_overrides.

It was causing symbol visibility errors in the WebRTC component build
and after looking more carefully into it, it seems that WebRTC doesn't
need it, it is used in //jingle so this CL moves the dependency where
it is needed.

Bug: 896154
Change-Id: Icf24838a7b6220d5cabce1878b128caa3fe2fc9e
Reviewed-on: https://chromium-review.googlesource.com/c/1297359
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: default avatarHenrik Grunell <grunell@chromium.org>
Reviewed-by: default avatarSergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602433}
parent 841235c1
...@@ -28,6 +28,7 @@ static_library("jingle_glue") { ...@@ -28,6 +28,7 @@ static_library("jingle_glue") {
"//base/third_party/dynamic_annotations", "//base/third_party/dynamic_annotations",
"//net", "//net",
"//services/network:network_service", "//services/network:network_service",
"//third_party/libjingle_xmpp:rtc_task_runner",
] ]
configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
...@@ -117,6 +118,7 @@ static_library("notifier") { ...@@ -117,6 +118,7 @@ static_library("notifier") {
"//net", "//net",
"//third_party/expat", "//third_party/expat",
"//url", "//url",
"//third_party/libjingle_xmpp:rtc_task_runner",
] ]
} }
...@@ -200,5 +202,6 @@ test("jingle_unittests") { ...@@ -200,5 +202,6 @@ test("jingle_unittests") {
"//services/network:test_support", "//services/network:test_support",
"//testing/gmock", "//testing/gmock",
"//testing/gtest", "//testing/gtest",
"//third_party/libjingle_xmpp:rtc_task_runner",
] ]
} }
...@@ -33,7 +33,6 @@ source_set("webrtc") { ...@@ -33,7 +33,6 @@ source_set("webrtc") {
# TODO(kjellander): Start cleaning up this target as soon as # TODO(kjellander): Start cleaning up this target as soon as
# https://codereview.chromium.org/2022833002/ is landed. The target should # https://codereview.chromium.org/2022833002/ is landed. The target should
# be removed entirely if possible. # be removed entirely if possible.
"//third_party/libjingle_xmpp:rtc_task_runner",
"//third_party/webrtc/rtc_base:rtc_base_approved", "//third_party/webrtc/rtc_base:rtc_base_approved",
] ]
deps = [ deps = [
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment