Commit 061a496e authored by jln@chromium.org's avatar jln@chromium.org

Revert of Linux sandbox: add sandbox_linux_unittests.isolate...

Revert of Linux sandbox: add sandbox_linux_unittests.isolate (https://codereview.chromium.org/340523006/)

Reason for revert:
Breaking linux_chromium_clang_dbg 

[7609/24970 | 449.637] SOLINK lib/libmojo_launcher.so
FAILED: cd ../../sandbox; python ../tools/isolate_driver.py check --isolated "../out/Debug/sandbox_linux_unittests.isolated" --isolate "linux/sandbox_linux_unittests.isolate" --path-variable DEPTH .. --path-variable PRODUCT_DIR "../out/Debug " --extra-variable "version_full=37.0.2056.0" --config-variable "OS=linux" --config-variable "chromeos=0" --config-variable "component=shared_library" --config-variable "internal_gles2_conform_tests=0" --config-variable "icu_use_data_file_flag=1" --config-variable "libpeer_target_type=static_library" --config-variable "use_openssl=0" --ignore_broken_items
Traceback (most recent call last):
  File "../tools/isolate_driver.py", line 279, in <module>
    sys.exit(main())
  File "../tools/isolate_driver.py", line 269, in main
    create_wrapper(args, isolate, isolated)
  File "../tools/isolate_driver.py", line 194, in create_wrapper
    assert os.path.basename(isolate) == isolate, isolate
AssertionError: linux/sandbox_linux_unittests.isolate
ninja: build stopped: subcommand failed.


Original issue's description:
> Linux sandbox: add sandbox_linux_unittests.isolate
> 
> BUG=384514
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277867

TBR=nodir@chromium.org,vadimsh@chromium.org,maruel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=384514

Review URL: https://codereview.chromium.org/339183007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277875 0039d316-1c4b-4281-b951-d872f2087c98
parent 80539702
...@@ -344,23 +344,5 @@ ...@@ -344,23 +344,5 @@
} }
], ],
}], }],
['test_isolation_mode != "noop"', {
'targets': [
{
'target_name': 'sandbox_linux_unittests_run',
'type': 'none',
'dependencies': [
'sandbox_linux_unittests',
],
'includes': [
'../../build/isolate.gypi',
'sandbox_linux_unittests.isolate',
],
'sources': [
'sandbox_linux_unittests.isolate',
],
},
],
}],
], ],
} }
# Copyright 2014 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
{
'conditions': [
['OS=="android" or OS=="linux"', {
'variables': {
'command': [
'<(PRODUCT_DIR)/sandbox_linux_unittests',
],
'isolate_dependency_tracked': [
'<(PRODUCT_DIR)/sandbox_linux_unittests',
],
'read_only': 1,
},
}],
],
'includes': [
# This is needed because of base/ dependencies on
# icudtl.dat.
'../../base/base.isolate',
],
}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment