Convert UpdateClientFactory to RepeatingCallback

TestExtensionsBrowserClient allows passing a factory callback that can
be used to create UpdateClients. By nature of being a factory, this
should be a repeating callback. We also pass it by value to indicate a
transfer of ownership.

No change to (the only) call site as it already uses BindRepeating.

Bug: 1152268
Change-Id: Ib07a63a48614fe3bb52b8fc060dd3946f64ec42f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605874Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840910}

extensions/browser/test_extensions_browser_client.cc

@@ -35,8 +35,8 @@ TestExtensionsBrowserClient::TestExtensionsBrowserClient()
 TestExtensionsBrowserClient::~TestExtensionsBrowserClient() = default;
 
 void TestExtensionsBrowserClient::SetUpdateClientFactory(
-    const base::Callback<update_client::UpdateClient*(void)>& factory) {
-  update_client_factory_ = factory;
+    base::RepeatingCallback<update_client::UpdateClient*(void)> factory) {
+  update_client_factory_ = std::move(factory);
 }
 
 void TestExtensionsBrowserClient::SetMainContext(

extensions/browser/test_extensions_browser_client.h

@@ -55,7 +55,7 @@ class TestExtensionsBrowserClient : public ExtensionsBrowserClient {
 
   // Sets a factory to respond to calls of the CreateUpdateClient method.
   void SetUpdateClientFactory(
-      const base::Callback<update_client::UpdateClient*(void)>& factory);
+      base::RepeatingCallback<update_client::UpdateClient*(void)> factory);
 
   // Sets the main browser context. Only call if a BrowserContext was not
   // already provided. |main_context| must not be an incognito context.
@@ -168,7 +168,8 @@ class TestExtensionsBrowserClient : public ExtensionsBrowserClient {
 
   std::unique_ptr<ExtensionCache> extension_cache_;
 
-  base::Callback<update_client::UpdateClient*(void)> update_client_factory_;
+  base::RepeatingCallback<update_client::UpdateClient*(void)>
+      update_client_factory_;
 };
 
 }  // namespace extensions