Commit 062df280 authored by riesa's avatar riesa Committed by Commit bot

Implements ChineseScriptClassifier functionality without icu::Transliterator

BUG=684609

Review-Url: https://codereview.chromium.org/2743843002
Cr-Commit-Position: refs/heads/master@{#456243}
parent e6f6e104
...@@ -7,14 +7,14 @@ ...@@ -7,14 +7,14 @@
#include <memory> #include <memory>
#include <string> #include <string>
#include "third_party/icu/source/i18n/unicode/translit.h" #include "third_party/icu/source/common/unicode/uniset.h"
namespace translate { namespace translate {
class ChineseScriptClassifier { class ChineseScriptClassifier {
public: public:
// Initializes both the Hant-to-Hans ICU transliterator and the // Initializes both the zh-Hans and zh-Hant UnicodeSets used for
// Hans-to-Hant ICU transliterator. // lookup when Classify is called.
ChineseScriptClassifier(); ChineseScriptClassifier();
~ChineseScriptClassifier(); ~ChineseScriptClassifier();
...@@ -31,11 +31,11 @@ class ChineseScriptClassifier { ...@@ -31,11 +31,11 @@ class ChineseScriptClassifier {
bool IsInitialized() const; bool IsInitialized() const;
private: private:
// ICU Transliterator that does Hans to Hant conversion. // Set of chars generally unique to zh-Hans.
std::unique_ptr<icu::Transliterator> hans2hant_; std::unique_ptr<icu::UnicodeSet> hans_set_;
// ICU Transliterator that does Hant to Hans conversion. // Set of chars generally unique to zh-Hant.
std::unique_ptr<icu::Transliterator> hant2hans_; std::unique_ptr<icu::UnicodeSet> hant_set_;
}; };
} // namespace translate } // namespace translate
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment