Move signin_internals_util.cc|h ou of signin's :internal GN target

... into the components/signin/core/browser:browser target.

Additionally, the CL also removes needless includes to
signin_internals_util.h from signin_manager* and identity_manager.h

BUG=927308

Change-Id: I39d34969a565f6d357903cfe88cde634c4600380
Reviewed-on: https://chromium-review.googlesource.com/c/1448493Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#628272}

components/signin/core/browser/BUILD.gn

@@ -82,8 +82,6 @@ static_library("internals") {
     "profile_oauth2_token_service.h",
     "signin_client.cc",
     "signin_client.h",
-    "signin_internals_util.cc",
-    "signin_internals_util.h",
     "signin_manager.cc",
     "signin_manager.h",
     "signin_manager_base.cc",
@@ -144,6 +142,8 @@ static_library("browser") {
     "signin_error_controller.h",
     "signin_header_helper.cc",
     "signin_header_helper.h",
+    "signin_internals_util.cc",
+    "signin_internals_util.h",
     "signin_investigator.cc",
     "signin_investigator.h",
     "signin_status_metrics_provider.cc",

components/signin/core/browser/about_signin_internals.cc

@@ -25,7 +25,6 @@
 #include "components/signin/core/browser/gaia_cookie_manager_service.h"
 #include "components/signin/core/browser/profile_oauth2_token_service.h"
 #include "components/signin/core/browser/signin_client.h"
-#include "components/signin/core/browser/signin_internals_util.h"
 #include "components/signin/core/browser/signin_switches.h"
 #include "google_apis/gaia/oauth2_token_service_delegate.h"
 #include "net/base/backoff_entry.h"

components/signin/core/browser/about_signin_internals.h

@@ -16,6 +16,7 @@
 #include "components/keyed_service/core/keyed_service.h"
 #include "components/signin/core/browser/signin_client.h"
 #include "components/signin/core/browser/signin_error_controller.h"
+#include "components/signin/core/browser/signin_internals_util.h"
 #include "google_apis/gaia/oauth2_token_service.h"
 #include "services/identity/public/cpp/identity_manager.h"
 

components/signin/core/browser/signin_manager.cc

@@ -17,7 +17,6 @@
 #include "components/signin/core/browser/account_tracker_service.h"
 #include "components/signin/core/browser/gaia_cookie_manager_service.h"
 #include "components/signin/core/browser/identity_utils.h"
-#include "components/signin/core/browser/signin_internals_util.h"
 #include "components/signin/core/browser/signin_metrics.h"
 #include "components/signin/core/browser/signin_pref_names.h"
 #include "google_apis/gaia/gaia_auth_util.h"

components/signin/core/browser/signin_manager.h

@@ -40,7 +40,6 @@
 #include "components/signin/core/browser/account_tracker_service.h"
 #include "components/signin/core/browser/profile_oauth2_token_service.h"
 #include "components/signin/core/browser/signin_client.h"
-#include "components/signin/core/browser/signin_internals_util.h"
 #include "components/signin/core/browser/signin_manager_base.h"
 #include "components/signin/core/browser/signin_metrics.h"
 #include "net/cookies/canonical_cookie.h"

components/signin/core/browser/signin_manager_base.h

@@ -35,7 +35,6 @@
 #include "components/prefs/pref_change_registrar.h"
 #include "components/prefs/pref_member.h"
 #include "components/signin/core/browser/account_info.h"
-#include "components/signin/core/browser/signin_internals_util.h"
 #include "google_apis/gaia/google_service_auth_error.h"
 
 class AccountTrackerService;

services/identity/public/cpp/DEPS

@@ -8,7 +8,6 @@ include_rules = [
   "+components/signin/core/browser/list_accounts_test_utils.h",
   "+components/signin/core/browser/account_consistency_method.h",
   "+components/signin/core/browser/signin_buildflags.h",
-  "+components/signin/core/browser/signin_internals_util.h",
   "+components/signin/core/browser/signin_metrics.h",
   "+components/signin/core/browser/signin_switches.h",
   "+components/signin/core/browser/ubertoken_fetcher_impl.h",

services/identity/public/cpp/identity_manager.h

@@ -10,7 +10,6 @@
 #include "components/signin/core/browser/account_tracker_service.h"
 #include "components/signin/core/browser/gaia_cookie_manager_service.h"
 #include "components/signin/core/browser/profile_oauth2_token_service.h"
-#include "components/signin/core/browser/signin_internals_util.h"
 #include "components/signin/core/browser/signin_manager_base.h"
 #include "components/signin/core/browser/signin_metrics.h"
 #include "components/signin/core/browser/ubertoken_fetcher.h"