Translate: Bug fix: Wrong way to check if the window is minimized

Before this CL, to check if the window is minimized, !IsActive() was
used. This function returns false when the bubble window is focused on
Windows or Chrome OS. Therefore, the bubble was not updated when the
bubble is already shown.

This CL fixes this bug by replacing !IsActive() with IsMinimize() to
check the state of Window properly.

BUG=393136, 389014 (the original CL about the bug around minimized window)
TEST=manual

Review URL: https://codereview.chromium.org/428583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287448 0039d316-1c4b-4281-b951-d872f2087c98
parent 5b5f2cf9
...@@ -1174,7 +1174,7 @@ void BrowserView::ShowTranslateBubble( ...@@ -1174,7 +1174,7 @@ void BrowserView::ShowTranslateBubble(
chrome_translate_client->GetLanguageState(); chrome_translate_client->GetLanguageState();
language_state.SetTranslateEnabled(true); language_state.SetTranslateEnabled(true);
if (!IsActive()) if (IsMinimized())
return; return;
TranslateBubbleView::ShowBubble( TranslateBubbleView::ShowBubble(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment