Skip to content

GitLab

T
tangled
Commit 06477a0b authored by Jérôme Lebel's avatar Jérôme Lebel Committed by Commit Bot
Browse files
Options

[Identity] Fixing DCHECK when signing out 

Need to use gaia::AreEmailsSame() instead of comparing emails directly.
Also, DCHECK_EQ() should be used instead of DCHECK().

Bug: 866801
Change-Id: I229e6aef631dca1f6ecf4c0242a11db15687d25a
Reviewed-on: https://chromium-review.googlesource.com/1148206Reviewed-by: default avatarMihai Sardarescu <msarda@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577489}
parent 51eccfb1
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 3 deletions
services/identity/public/cpp/identity_manager.cc
View file @ 06477a0b
...@@ -260,9 +260,9 @@ void IdentityManager::WillFireGoogleSignedOut(const AccountInfo& account_info) { ...@@ -260,9 +260,9 @@ void IdentityManager::WillFireGoogleSignedOut(const AccountInfo& account_info) {
// TODO(843510): Consider setting this info and notifying observers // TODO(843510): Consider setting this info and notifying observers
// asynchronously in response to GoogleSigninSucceeded() once there are no // asynchronously in response to GoogleSigninSucceeded() once there are no
// direct clients of SigninManager. // direct clients of SigninManager.
DCHECK(account_info.account_id == primary_account_info_.account_id); DCHECK_EQ(account_info.account_id, primary_account_info_.account_id);
DCHECK(account_info.gaia == primary_account_info_.gaia); DCHECK_EQ(account_info.gaia, primary_account_info_.gaia);
DCHECK(account_info.email == primary_account_info_.email); DCHECK(gaia::AreEmailsSame(account_info.email, primary_account_info_.email));
primary_account_info_ = AccountInfo(); primary_account_info_ = AccountInfo();
} }
#endif #endif
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment