Commit 0666b951 authored by Jacobo Aragunde Pérez's avatar Jacobo Aragunde Pérez Committed by Commit Bot

Remove dead code from BubbleDialogDelegateView.

The use of up and down to manage focus inside bubbles is managed by
FocusManager::ProcessArrowKeyTraversal since
https://crrev.com/c/2503988

Bug: None
Change-Id: I3a0e0afac38b07080fcbf65231e123b6ef0fa6d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537671Reviewed-by: default avatarDana Fried <dfried@chromium.org>
Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Cr-Commit-Position: refs/heads/master@{#827587}
parent 2807735c
...@@ -409,17 +409,6 @@ ClientView* BubbleDialogDelegate::CreateClientView(Widget* widget) { ...@@ -409,17 +409,6 @@ ClientView* BubbleDialogDelegate::CreateClientView(Widget* widget) {
return client_view_; return client_view_;
} }
bool BubbleDialogDelegateView::AcceleratorPressed(
const ui::Accelerator& accelerator) {
if (accelerator.key_code() == ui::VKEY_DOWN ||
accelerator.key_code() == ui::VKEY_UP) {
// Move the focus up or down.
GetFocusManager()->AdvanceFocus(accelerator.key_code() != ui::VKEY_DOWN);
return true;
}
return View::AcceleratorPressed(accelerator);
}
Widget* BubbleDialogDelegateView::GetWidget() { Widget* BubbleDialogDelegateView::GetWidget() {
return View::GetWidget(); return View::GetWidget();
} }
......
...@@ -12,7 +12,6 @@ ...@@ -12,7 +12,6 @@
#include "base/scoped_observer.h" #include "base/scoped_observer.h"
#include "build/build_config.h" #include "build/build_config.h"
#include "ui/accessibility/ax_enums.mojom-forward.h" #include "ui/accessibility/ax_enums.mojom-forward.h"
#include "ui/base/accelerators/accelerator.h"
#include "ui/base/class_property.h" #include "ui/base/class_property.h"
#include "ui/views/bubble/bubble_border.h" #include "ui/views/bubble/bubble_border.h"
#include "ui/views/bubble/bubble_frame_view.h" #include "ui/views/bubble/bubble_frame_view.h"
...@@ -31,10 +30,6 @@ namespace gfx { ...@@ -31,10 +30,6 @@ namespace gfx {
class Rect; class Rect;
} }
namespace ui {
class Accelerator;
} // namespace ui
namespace ui_devtools { namespace ui_devtools {
class PageAgentViews; class PageAgentViews;
} }
...@@ -411,7 +406,6 @@ class VIEWS_EXPORT BubbleDialogDelegateView : public BubbleDialogDelegate, ...@@ -411,7 +406,6 @@ class VIEWS_EXPORT BubbleDialogDelegateView : public BubbleDialogDelegate,
Widget* GetWidget() override; Widget* GetWidget() override;
const Widget* GetWidget() const override; const Widget* GetWidget() const override;
void AddedToWidget() override; void AddedToWidget() override;
bool AcceleratorPressed(const ui::Accelerator& accelerator) override;
protected: protected:
// Disallow overrides of GetMinimumSize and GetMaximumSize(). These would only // Disallow overrides of GetMinimumSize and GetMaximumSize(). These would only
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment