Commit 0676e1c1 authored by Ian Barkley-Yeung's avatar Ian Barkley-Yeung Committed by Commit Bot

Noted important log messages

Noted that two vlog messages in BrokerProcess::Init() are going to be
referenced from ChromeOS integration tests, to warn people not to change
them.

https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/2006009
is the CL adding the reference.

BUG=chromium:1038463
TEST=tast -verbose run --extrauseflags chrome_internal  my_crbook ui.ChromeCrashLoggedIn.* ui.ChromeCrashNotLoggedIn.* with this and 2006009 and 2004088

Change-Id: I4bec0bcdbb9fae631e4311d746fbb68a416f3709
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006188Reviewed-by: default avatarRobert Sesek <rsesek@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Auto-Submit: Ian Barkley-Yeung <iby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736216}
parent 76a53a3c
......@@ -73,6 +73,9 @@ bool BrokerProcess::Init(
return false;
if (child_pid) {
// This string is referenced in a ChromeOS integration test; do not change.
// TODO(crbug.com/1044502): If we can fix setproctitle, the integration
// test not longer needs to look for this message.
VLOG(3) << "BrokerProcess::Init(), in parent, child is " << child_pid;
// We are the parent and we have just forked our broker process.
ipc_reader.reset();
......@@ -84,9 +87,13 @@ bool BrokerProcess::Init(
return true;
}
// This string is referenced in a ChromeOS integration test; do not change.
// TODO(crbug.com/1044502): If we can fix setproctitle, the integration test
// not longer needs to look for this message.
VLOG(3) << "BrokerProcess::Init(), in child";
// We are the broker process. Make sure to close the writer's end so that
// we get notified if the client disappears.
VLOG(3) << "BrokerProcess::Init(), in child";
ipc_writer.reset();
CHECK(std::move(broker_process_init_callback).Run());
BrokerHost broker_host(broker_permission_list_, allowed_command_set_,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment