Commit 06854c5c authored by dglazkov's avatar dglazkov Committed by Commit bot

Revert of Move text/selection update to the back of pipeline (patchset #3...

Revert of Move text/selection update to the back of pipeline (patchset #3 id:40001 of https://codereview.chromium.org/2267933002/ )

Reason for revert:
Need to do more testing/thinking.

Original issue's description:
> Move text/selection update to the back of pipeline
>
> Instead of forcing the spurious rendering pipeline flush to get an updated selection and text input information (for IME), do after the layout and style information had updated.
>
> BUG=640310
>
> Committed: https://crrev.com/aa7d9e29b66032b9289769d2948c2b8a394ed4b0
> Cr-Commit-Position: refs/heads/master@{#415483}

TBR=chrishtr@chromium.org,esprehn@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=640310

Review-Url: https://codereview.chromium.org/2295013002
Cr-Commit-Position: refs/heads/master@{#415509}
parent 4cd50edf
......@@ -830,13 +830,17 @@ void RenderWidget::RequestScheduleAnimation() {
void RenderWidget::UpdateVisualState() {
webwidget_->updateAllLifecyclePhases();
UpdateTextInputState(ShowIme::HIDE_IME, ChangeSource::FROM_NON_IME);
UpdateSelectionBounds();
}
void RenderWidget::WillBeginCompositorFrame() {
TRACE_EVENT0("gpu", "RenderWidget::willBeginCompositorFrame");
// The UpdateTextInputState can result in further layout and possibly
// enable GPU acceleration so they need to be called before any painting
// is done.
UpdateTextInputState(ShowIme::HIDE_IME, ChangeSource::FROM_NON_IME);
UpdateSelectionBounds();
FOR_EACH_OBSERVER(RenderFrameProxy, render_frame_proxies_,
WillBeginCompositorFrame());
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment