Commit 06979b62 authored by girard@chromium.org's avatar girard@chromium.org

~GestureRecognizerImpl() was leaking memory. Now it doesn't. An unfortunate...

~GestureRecognizerImpl() was leaking memory.  Now it doesn't.  An unfortunate side effect of this leak was that GestureSequence objects hold a pointer to the GR's parent window (helper_) that is no longer valid after the dtor is called.  They also hold a callback timer, which fires for a long press...

This CL fixes the crash in issue 139420, but it doesn't fix the full bug.  Specifically, the popup menu is still not responding to touch.

BUG=139420

Review URL: https://chromiumcodereview.appspot.com/10826117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149957 0039d316-1c4b-4281-b951-d872f2087c98
parent 565ae4c5
......@@ -170,6 +170,8 @@ GestureRecognizerImpl::GestureRecognizerImpl(GestureEventHelper* helper)
}
GestureRecognizerImpl::~GestureRecognizerImpl() {
STLDeleteValues(&consumer_sequence_);
STLDeleteValues(&event_queue_);
}
// Checks if this finger is already down, if so, returns the current target.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment