Commit 06aa0e18 authored by Stephen McGruer's avatar Stephen McGruer Committed by Commit Bot

Remove crash keys in PDF accessibility tree

The crash that these were meant to help debug has been long fixed.
They are no longer needed.

Bug: 770886
Change-Id: I7abf99be6cd00b9ae9a99934edaca95fe48e638d
Reviewed-on: https://chromium-review.googlesource.com/1174992Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583341}
parent 5619f416
...@@ -4,7 +4,6 @@ ...@@ -4,7 +4,6 @@
#include <algorithm> #include <algorithm>
#include "base/debug/crash_logging.h"
#include "base/i18n/break_iterator.h" #include "base/i18n/break_iterator.h"
#include "base/memory/ptr_util.h" #include "base/memory/ptr_util.h"
#include "base/strings/stringprintf.h" #include "base/strings/stringprintf.h"
...@@ -210,18 +209,8 @@ void PdfAccessibilityTree::Finish() { ...@@ -210,18 +209,8 @@ void PdfAccessibilityTree::Finish() {
for (const auto& node : nodes_) for (const auto& node : nodes_)
update.nodes.push_back(*node); update.nodes.push_back(*node);
if (!tree_.Unserialize(update)) { if (!tree_.Unserialize(update))
static auto* ax_tree_error = base::debug::AllocateCrashKeyString(
"ax_tree_error", base::debug::CrashKeySize::Size32);
static auto* ax_tree_update = base::debug::AllocateCrashKeyString(
"ax_tree_update", base::debug::CrashKeySize::Size64);
// Temporarily log some additional crash keys so we can try to
// figure out why we're getting bad accessibility trees here.
// http://crbug.com/770886
base::debug::SetCrashKeyString(ax_tree_error, tree_.error());
base::debug::SetCrashKeyString(ax_tree_update, update.ToString());
LOG(FATAL) << tree_.error(); LOG(FATAL) << tree_.error();
}
UpdateAXTreeDataFromSelection(); UpdateAXTreeDataFromSelection();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment