Commit 06c20e77 authored by mdjones's avatar mdjones Committed by Commit bot

Fix history for reader mode

When entering reader mode, it was possible to get into a state where
the distilled page would have a pending history entry and would not
have the rest of the history merged. This change moves the history
merge to before a new entry is set in the distilled web contents.

BUG=498576

Review URL: https://codereview.chromium.org/1171343002

Cr-Commit-Position: refs/heads/master@{#333739}
parent a2caf9a3
...@@ -640,6 +640,10 @@ public class ReaderModePanel implements ChromeAnimation.Animatable<ReaderModePan ...@@ -640,6 +640,10 @@ public class ReaderModePanel implements ChromeAnimation.Animatable<ReaderModePan
mDistilledContentViewCore = createDistillerContentViewCore( mDistilledContentViewCore = createDistillerContentViewCore(
mReaderModeHost.getTab().getContentViewCore().getContext(), mReaderModeHost.getTab().getContentViewCore().getContext(),
mReaderModeHost.getTab().getWindowAndroid()); mReaderModeHost.getTab().getWindowAndroid());
mergeNavigationHistory(mDistilledContentViewCore.getWebContents(),
mReaderModeHost.getTab().getWebContents());
mDistilledContentObserver = new WebContentsObserver( mDistilledContentObserver = new WebContentsObserver(
mDistilledContentViewCore.getWebContents()) { mDistilledContentViewCore.getWebContents()) {
@Override @Override
...@@ -702,8 +706,6 @@ public class ReaderModePanel implements ChromeAnimation.Animatable<ReaderModePan ...@@ -702,8 +706,6 @@ public class ReaderModePanel implements ChromeAnimation.Animatable<ReaderModePan
mDistilledContentObserver = null; mDistilledContentObserver = null;
mDistilledContentViewCore.setContentViewClient(new ContentViewClient()); mDistilledContentViewCore.setContentViewClient(new ContentViewClient());
mergeNavigationHistory(mDistilledContentViewCore.getWebContents(),
mReaderModeHost.getTab().getWebContents());
mReaderModeHost.getTab().swapContentViewCore(mDistilledContentViewCore, true, mReaderModeHost.getTab().swapContentViewCore(mDistilledContentViewCore, true,
mDidStartLoad, mDidFinishLoad); mDidStartLoad, mDidFinishLoad);
mDistilledContentViewCore.getContentViewClient().onOffsetsForFullscreenChanged( mDistilledContentViewCore.getContentViewClient().onOffsetsForFullscreenChanged(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment