Commit 06dc4c4f authored by mfoltz's avatar mfoltz Committed by Commit bot

Remove DCHECK in DialRegistry dtor. This may trigger on browser shutdown if

there are event listeners still registered with chrome.dial.  This is not an
issue as all owned objects will be cleaned up anyway by following the normal dtor
sequence DialAPI -> DialRegistry -> DialService.

BUG=460197

Review URL: https://codereview.chromium.org/916103007

Cr-Commit-Position: refs/heads/master@{#317194}
parent 2f612699
...@@ -21,6 +21,10 @@ class DialRegistry; ...@@ -21,6 +21,10 @@ class DialRegistry;
// the DIAL registry. It takes care of creating the registry on the IO thread // the DIAL registry. It takes care of creating the registry on the IO thread
// and is an observer of the registry. It makes sure devices events are sent out // and is an observer of the registry. It makes sure devices events are sent out
// to extension listeners on the right thread. // to extension listeners on the right thread.
//
// TODO(mfoltz): This should probably inherit from BrowserContextKeyedAPI
// instead; ShutdownOnUIThread below is a no-op, which is the whole point of
// RefcountedKeyedService.
class DialAPI : public RefcountedKeyedService, class DialAPI : public RefcountedKeyedService,
public EventRouter::Observer, public EventRouter::Observer,
public DialRegistry::Observer { public DialRegistry::Observer {
......
...@@ -42,7 +42,6 @@ DialRegistry::DialRegistry(Observer* dial_api, ...@@ -42,7 +42,6 @@ DialRegistry::DialRegistry(Observer* dial_api,
DialRegistry::~DialRegistry() { DialRegistry::~DialRegistry() {
DCHECK(thread_checker_.CalledOnValidThread()); DCHECK(thread_checker_.CalledOnValidThread());
DCHECK_EQ(0, num_listeners_);
NetworkChangeNotifier::RemoveNetworkChangeObserver(this); NetworkChangeNotifier::RemoveNetworkChangeObserver(this);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment