Commit 0708646a authored by Guillaume Jenkins's avatar Guillaume Jenkins Committed by Commit Bot

[iOS CBCM] Enable CBCM at 100% on Beta

Enables CBCM at 100% on Beta on iOS (in addition to the existing
command-line switch, which can enable CBCM in any channel). To
paraphrase the comment in the code, CBCM must either be enabled
at 100% or 0% because the Finch infrastructure isn't ready by the
time CBCM must decide whether to initialize.

Because of additional requirements explained in the following 1-pager
(Google only), CBCM is required on Beta, which means CBCM will be
enabled at 100% on Beta and 0% on all other channels:
go/ios-cbcm-rollout-1pager.

Bug: 1066495
Change-Id: I1449f5314ea592297d79ec7acbbb0991d31bed5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364912
Commit-Queue: Guillaume Jenkins <gujen@google.com>
Reviewed-by: default avatarsebsg <sebsg@chromium.org>
Reviewed-by: default avatarMike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800330}
parent 262a23a8
...@@ -41,7 +41,16 @@ bool IsDisableEnterprisePolicySwitchPresent() { ...@@ -41,7 +41,16 @@ bool IsDisableEnterprisePolicySwitchPresent() {
} // namespace } // namespace
bool IsChromeBrowserCloudManagementEnabled() { bool IsChromeBrowserCloudManagementEnabled() {
return HasSwitch(switches::kEnableChromeBrowserCloudManagement); // This method is called very early during the launch sequence (inside
// IOSChromeMainParts::PreCreateThreads). At that point, the FeatureList API
// isn't ready yet, so neither Finch experiments nor first-run field trials
// can be used for progressive rollout. To ensure adequate coverage of both
// the "CBCM disabled" and "CBCM enabled" code paths, CBCM is enabled at 100%
// on Beta and 0% on all other channels (CBCM is disabled by default). This
// allows monitoring crashes for both code paths while allowing early adopters
// to use CBCM on the Beta channel.
return HasSwitch(switches::kEnableChromeBrowserCloudManagement) ||
GetChannel() == version_info::Channel::BETA;
} }
bool IsEditBookmarksIOSEnabled() { bool IsEditBookmarksIOSEnabled() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment