Enable "gn check" for //third_party/blink/renderer/platform/loader

This CL changes the default visibility of "blink_platform_sources"
template so that it is exposed to all of targets under
renderer/platform/ including its sub-directories.

This CL has no behavior changes.

Bug: 800764
Change-Id: I046766a226b5e95917ca7ba8a89550db5dc9c219
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400788Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805621}

.gn

@@ -257,7 +257,6 @@ no_check_targets = [
   "//third_party/blink/renderer/modules/peerconnection:*",  # 43 errors
   "//third_party/blink/renderer/modules/webtransport:*",  # 16 errors
   "//third_party/blink/renderer/modules:*",  # 321 errors
-  "//third_party/blink/renderer/platform/loader:*",  # 180 errors
   "//third_party/blink/renderer/platform/network:*",  # 15 errors
   "//third_party/blink/renderer/platform:*",  # 72 errors
 

third_party/blink/renderer/platform/BUILD.gn

@@ -1563,6 +1563,7 @@ component("platform") {
     "//third_party/blink/renderer/platform/blob",
     "//third_party/blink/renderer/platform/heap:heap",
     "//third_party/blink/renderer/platform/instrumentation",
+    "//third_party/blink/renderer/platform/loader:loader",
     "//third_party/blink/renderer/platform/scheduler",
   ]
 
@@ -1820,6 +1821,8 @@ static_library("test_support") {
     "//third_party/blink/renderer/platform/heap:test_support",
     "//third_party/blink/renderer/platform/network:test_support",
   ]
+  allow_circular_includes_from =
+      [ "//third_party/blink/renderer/platform/loader:test_support" ]
 
   if (is_win) {
     cflags = [ "/wd4267" ]  # Truncation from size_t to int.

third_party/blink/renderer/platform/heap/BUILD.gn

@@ -122,6 +122,7 @@ blink_platform_sources("heap") {
   visibility = [
     "//third_party/blink/renderer/platform:platform",
     "//third_party/blink/renderer/platform/instrumentation:instrumentation",
+    "//third_party/blink/renderer/platform/loader:loader",
     "//third_party/blink/renderer/platform/scheduler:scheduler",
   ]
 }

third_party/blink/renderer/platform/instrumentation/BUILD.gn

@@ -5,13 +5,6 @@
 import("//third_party/blink/renderer/platform/platform.gni")
 
 blink_platform_sources("instrumentation") {
-  visibility = []
-  visibility = [
-    "//third_party/blink/renderer/platform",
-    "//third_party/blink/renderer/platform/blob",
-    "//third_party/blink/renderer/platform/scheduler",
-  ]
-
   sources = [
     "canvas_memory_dump_provider.cc",
     "canvas_memory_dump_provider.h",

third_party/blink/renderer/platform/loader/BUILD.gn

@@ -141,9 +141,15 @@ blink_platform_sources("loader") {
     ":make_platform_loader_generated_fetch_initiator_type_names",
     "//components/link_header_util",
     "//components/web_package",
+    "//services/metrics/public/cpp:ukm_builders",
     "//services/network/public/cpp",
     "//services/network/public/mojom:mojom_blink",
+    "//third_party/blink/renderer/platform/blob:blob",
+    "//third_party/blink/renderer/platform/instrumentation:instrumentation",
+    "//third_party/blink/renderer/platform/network:network",
+    "//third_party/blink/renderer/platform/scheduler:scheduler",
   ]
+  public_deps = [ "//third_party/blink/renderer/platform/heap:heap" ]
 }
 
 source_set("unit_tests") {
@@ -187,11 +193,16 @@ source_set("unit_tests") {
   configs += [ "//third_party/blink/renderer/platform:blink_platform_config" ]
 
   deps = [
+    "//base/test:test_support",
     "//components/web_package:test_support",
+    "//mojo/public/cpp/test_support:test_utils",
+    "//net/traffic_annotation:test_support",
     "//services/network:test_support",
     "//testing/gmock",
     "//testing/gtest",
+    "//third_party/blink/public:test_headers",
     "//third_party/blink/renderer/platform:platform",
+    "//third_party/blink/renderer/platform:test_support",
   ]
 }
 
@@ -232,6 +243,7 @@ source_set("test_support") {
     "//third_party/blink/public:blink_headers",
     "//third_party/blink/renderer/platform:platform",
     "//third_party/blink/renderer/platform/blob:generator",
+    "//third_party/blink/renderer/platform/scheduler:test_support",
     "//third_party/icu",
   ]
 }

third_party/blink/renderer/platform/platform.gni

@@ -18,7 +18,7 @@ template("blink_platform_sources") {
   source_set(target_name) {
     # Only platform can directly depend on this.
     # Any target outside platform should instead depend on platform.
-    visibility = [ "//third_party/blink/renderer/platform" ]
+    visibility = [ "//third_party/blink/renderer/platform/*" ]
 
     deps =
         [ "//third_party/blink/renderer/platform:blink_platform_public_deps" ]

third_party/blink/renderer/platform/scheduler/BUILD.gn

@@ -7,11 +7,6 @@ import("//third_party/blink/renderer/platform/platform.gni")
 import("//third_party/protobuf/proto_library.gni")
 
 blink_platform_sources("scheduler") {
-  visibility = [
-    "//third_party/blink/renderer/platform",
-    "//third_party/blink/renderer/platform/blob",
-  ]
-
   sources = [
     "common/cancelable_closure_holder.cc",
     "common/cancelable_closure_holder.h",