Commit 074da65f authored by yuzus's avatar yuzus Committed by Commit bot

Change Event.deepPath to a method

In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>.
See the discussion here: https://github.com/w3c/webcomponents/issues/361
Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-EventTarget
See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76c87d56c
BUG=531990

Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957
Cr-Commit-Position: refs/heads/master@{#372596}

Review URL: https://codereview.chromium.org/1637813002

Cr-Commit-Position: refs/heads/master@{#376103}
parent 965aad97
......@@ -7,8 +7,8 @@
img.onload = function(e) {
test(function() {
assert_array_equals(e.deepPath, e.path);
}, "Event.deepPath should be the same as Event.path.");
assert_array_equals(e.deepPath(), e.path);
}, "Event.deepPath() should be the same as Event.path.");
};
</script>
......@@ -47,7 +47,7 @@ bubbles : 'false'
cancelBubble : 'false'
cancelable : 'false'
currentTarget : '[object XMLHttpRequest]'
deepPath : ''
deepPath : 'function deepPath() { [native code] }'
defaultPrevented : 'false'
eventPhase : '2'
initEvent : 'function initEvent() { [native code] }'
......
......@@ -145,7 +145,6 @@ interface Event
getter cancelBubble
getter cancelable
getter currentTarget
getter deepPath
getter defaultPrevented
getter eventPhase
getter path
......@@ -156,6 +155,7 @@ interface Event
getter timeStamp
getter type
method constructor
method deepPath
method initEvent
method preventDefault
method stopImmediatePropagation
......
......@@ -148,7 +148,6 @@ Starting worker: resources/global-interface-listing.js
[Worker] getter cancelBubble
[Worker] getter cancelable
[Worker] getter currentTarget
[Worker] getter deepPath
[Worker] getter defaultPrevented
[Worker] getter eventPhase
[Worker] getter path
......@@ -159,6 +158,7 @@ Starting worker: resources/global-interface-listing.js
[Worker] getter timeStamp
[Worker] getter type
[Worker] method constructor
[Worker] method deepPath
[Worker] method initEvent
[Worker] method preventDefault
[Worker] method stopImmediatePropagation
......
......@@ -1396,7 +1396,6 @@ interface Event
getter cancelBubble
getter cancelable
getter currentTarget
getter deepPath
getter defaultPrevented
getter eventPhase
getter path
......@@ -1407,6 +1406,7 @@ interface Event
getter timeStamp
getter type
method constructor
method deepPath
method initEvent
method preventDefault
method stopImmediatePropagation
......
......@@ -136,7 +136,6 @@ Starting worker: resources/global-interface-listing.js
[Worker] getter cancelBubble
[Worker] getter cancelable
[Worker] getter currentTarget
[Worker] getter deepPath
[Worker] getter defaultPrevented
[Worker] getter eventPhase
[Worker] getter path
......@@ -147,6 +146,7 @@ Starting worker: resources/global-interface-listing.js
[Worker] getter timeStamp
[Worker] getter type
[Worker] method constructor
[Worker] method deepPath
[Worker] method initEvent
[Worker] method preventDefault
[Worker] method stopImmediatePropagation
......
......@@ -66,7 +66,8 @@
// Shadow DOM
// https://w3c.github.io/webcomponents/spec/shadow/#extensions-to-event-interface
[MeasureAs=EventPath, CallWith=ScriptState] readonly attribute EventTarget[] path;
[RuntimeEnabled=ShadowDOMV1, ImplementedAs=path, MeasureAs=EventDeepPath, CallWith=ScriptState] readonly attribute EventTarget[] deepPath;
[RuntimeEnabled=ShadowDOMV1, ImplementedAs=path, MeasureAs=EventDeepPath, CallWith=ScriptState] sequence<EventTarget> deepPath();
// Non-standard APIs
const unsigned short MOUSEDOWN = 1;
const unsigned short MOUSEUP = 2;
......
......@@ -33,7 +33,7 @@ WebInspector.Tooltip.prototype = {
*/
_mouseMove: function(event)
{
var path = event.path;
var path = event.deepPath() ? event.deepPath() : event.path;
if (!path || event.buttons !== 0)
return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment