Commit 075822e5 authored by Sven Zheng's avatar Sven Zheng Committed by Chromium LUCI CQ

Revert "Disabled flaky SingleClientTypedUrlsSyncTest tests on Android"

This reverts commit a23b68c3.

Reason for revert: Tests are fixed in crbug.com/1159404

Original change's description:
> Disabled flaky SingleClientTypedUrlsSyncTest tests on Android
>
> This CL disabled the following tests on Android.
>
> * SingleClientTypedUrlsSyncTest.DeleteNonTyped
> * SingleClientTypedUrlsSyncTest.TwoVisits
> * SingleClientTypedUrlsSyncTest.DeleteTyped
> * SingleClientTypedUrlsSyncTest.Sanity
>
> TBR=mastiz@chromium.org
>
> Bug: 1159479
> Change-Id: I49a93df85f6e48bbd661e77e41c467787c4e8b68
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596119
> Reviewed-by: Salvador Guerrero <salg@google.com>
> Commit-Queue: Salvador Guerrero <salg@google.com>
> Cr-Commit-Position: refs/heads/master@{#837747}

TBR=mastiz@chromium.org,salg@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I24bcdac6b58843f9ca7a1909f9720152d43845be
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1159479
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597744Reviewed-by: default avatarSven Zheng <svenzheng@chromium.org>
Reviewed-by: default avatarSalvador Guerrero <salg@google.com>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838969}
parent f0d63d31
......@@ -35,13 +35,7 @@ class SingleClientTypedUrlsSyncTest : public SyncTest {
}
};
// Flaky on android: https://crbug.com/1159479
#if defined(OS_ANDROID)
#define MAYBE_Sanity DISABLED_Sanity
#else
#define MAYBE_Sanity Sanity
#endif
IN_PROC_BROWSER_TEST_F(SingleClientTypedUrlsSyncTest, MAYBE_Sanity) {
IN_PROC_BROWSER_TEST_F(SingleClientTypedUrlsSyncTest, Sanity) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
history::URLRows urls = GetTypedUrlsFromClient(0);
ASSERT_EQ(0U, urls.size());
......@@ -59,13 +53,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientTypedUrlsSyncTest, MAYBE_Sanity) {
ASSERT_TRUE(CheckAllProfilesHaveSameTypedURLs());
}
// Flaky on android: https://crbug.com/1159479
#if defined(OS_ANDROID)
#define MAYBE_TwoVisits DISABLED_TwoVisits
#else
#define MAYBE_TwoVisits TwoVisits
#endif
IN_PROC_BROWSER_TEST_F(SingleClientTypedUrlsSyncTest, MAYBE_TwoVisits) {
IN_PROC_BROWSER_TEST_F(SingleClientTypedUrlsSyncTest, TwoVisits) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
history::URLRows urls = GetTypedUrlsFromClient(0);
ASSERT_EQ(0U, urls.size());
......@@ -85,13 +73,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientTypedUrlsSyncTest, MAYBE_TwoVisits) {
ASSERT_TRUE(CheckAllProfilesHaveSameTypedURLs());
}
// Flaky on android: https://crbug.com/1159479
#if defined(OS_ANDROID)
#define MAYBE_DeleteTyped DISABLED_DeleteTyped
#else
#define MAYBE_DeleteTyped DeleteTyped
#endif
IN_PROC_BROWSER_TEST_F(SingleClientTypedUrlsSyncTest, MAYBE_DeleteTyped) {
IN_PROC_BROWSER_TEST_F(SingleClientTypedUrlsSyncTest, DeleteTyped) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
history::URLRows urls = GetTypedUrlsFromClient(0);
ASSERT_EQ(0U, urls.size());
......@@ -118,13 +100,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientTypedUrlsSyncTest, MAYBE_DeleteTyped) {
ASSERT_TRUE(CheckAllProfilesHaveSameTypedURLs());
}
// Flaky on android: https://crbug.com/1159479
#if defined(OS_ANDROID)
#define MAYBE_DeleteNonTyped DISABLED_DeleteNonTyped
#else
#define MAYBE_DeleteNonTyped DeleteNonTyped
#endif
IN_PROC_BROWSER_TEST_F(SingleClientTypedUrlsSyncTest, MAYBE_DeleteNonTyped) {
IN_PROC_BROWSER_TEST_F(SingleClientTypedUrlsSyncTest, DeleteNonTyped) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
history::URLRows urls = GetTypedUrlsFromClient(0);
ASSERT_EQ(0U, urls.size());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment