Add remote_install flag to extension sync data.

This is the first step in adding support for remote installation of
extensions and apps.

BUG=365737

Review URL: https://codereview.chromium.org/264933005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268053 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/extensions/app_sync_data_unittest.cc

@@ -28,6 +28,7 @@ class AppSyncDataTest : public testing::Test {
     extension_specifics->set_version(kValidVersion);
     extension_specifics->set_enabled(false);
     extension_specifics->set_incognito_enabled(true);
+    extension_specifics->set_remote_install(false);
     extension_specifics->set_name(kName);
   }
 };

chrome/browser/extensions/extension_sync_data.cc

@@ -18,13 +18,15 @@ namespace extensions {
 ExtensionSyncData::ExtensionSyncData()
     : uninstalled_(false),
       enabled_(false),
-      incognito_enabled_(false) {
+      incognito_enabled_(false),
+      remote_install_(false) {
 }
 
 ExtensionSyncData::ExtensionSyncData(const syncer::SyncData& sync_data)
     : uninstalled_(false),
       enabled_(false),
-      incognito_enabled_(false) {
+      incognito_enabled_(false),
+      remote_install_(false) {
   PopulateFromSyncData(sync_data);
 }
 
@@ -32,7 +34,8 @@ ExtensionSyncData::ExtensionSyncData(const syncer::SyncChange& sync_change)
     : uninstalled_(
         sync_change.change_type() == syncer::SyncChange::ACTION_DELETE),
       enabled_(false),
-      incognito_enabled_(false) {
+      incognito_enabled_(false),
+      remote_install_(false) {
   PopulateFromSyncData(sync_change.sync_data());
 }
 
@@ -43,6 +46,7 @@ ExtensionSyncData::ExtensionSyncData(const Extension& extension,
       uninstalled_(false),
       enabled_(enabled),
       incognito_enabled_(incognito_enabled),
+      remote_install_(false),
       version_(extension.from_bookmark() ? base::Version("0")
                                          : *extension.version()),
       update_url_(ManifestURL::GetUpdateURL(&extension)),
@@ -71,6 +75,7 @@ void ExtensionSyncData::PopulateExtensionSpecifics(
   specifics->set_version(version_.GetString());
   specifics->set_enabled(enabled_);
   specifics->set_incognito_enabled(incognito_enabled_);
+  specifics->set_remote_install(remote_install_);
   specifics->set_name(name_);
 }
 
@@ -95,6 +100,7 @@ void ExtensionSyncData::PopulateFromExtensionSpecifics(
   version_ = specifics_version;
   enabled_ = specifics.enabled();
   incognito_enabled_ = specifics.incognito_enabled();
+  remote_install_ = specifics.remote_install();
   name_ = specifics.name();
 }
 

chrome/browser/extensions/extension_sync_data.h

@@ -72,6 +72,7 @@ class ExtensionSyncData {
   bool uninstalled_;
   bool enabled_;
   bool incognito_enabled_;
+  bool remote_install_;
   Version version_;
   GURL update_url_;
   std::string name_;

sync/protocol/extension_specifics.proto

@@ -35,5 +35,9 @@ message ExtensionSpecifics {
 
   // The name of the extension. Used for bookmark apps.
   optional string name = 6;
+
+  // Whether this extension was installed remotely, and hasn't been approved by
+  // a user in chrome yet.
+  optional bool remote_install = 7;
 }
 

sync/protocol/proto_value_conversions.cc

@@ -549,6 +549,7 @@ base::DictionaryValue* ExtensionSpecificsToValue(
   SET_STR(update_url);
   SET_BOOL(enabled);
   SET_BOOL(incognito_enabled);
+  SET_BOOL(remote_install);
   SET_STR(name);
   return value;
 }