Commit 0760d19a authored by Toni Barzic's avatar Toni Barzic Committed by Commit Bot

app list: Search box should not display empty result details

If omnibox result details are empty, the app list search box should
display the provided search result title instead of empty details.
(if the details are empty, the target URL is provided as result title)

BUG=1007030

Change-Id: Ia9f18a8375eaa562b3e63dd548905f1a7005e579
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816147Reviewed-by: default avatarJenny Zhang <jennyz@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700404}
parent cb06ba9e
...@@ -740,8 +740,9 @@ void SearchBoxView::ButtonPressed(views::Button* sender, ...@@ -740,8 +740,9 @@ void SearchBoxView::ButtonPressed(views::Button* sender,
void SearchBoxView::UpdateSearchBoxTextForSelectedResult( void SearchBoxView::UpdateSearchBoxTextForSelectedResult(
SearchResult* selected_result) { SearchResult* selected_result) {
if (selected_result->result_type() == ash::SearchResultType::kOmnibox && if (selected_result->result_type() == ash::SearchResultType::kOmnibox &&
!selected_result->is_omnibox_search()) { !selected_result->is_omnibox_search() &&
// Use details to ensure url results fill url. !selected_result->details().empty()) {
// If set, use details to ensure url results fill url.
search_box()->SetText(selected_result->details()); search_box()->SetText(selected_result->details());
} else { } else {
search_box()->SetText(selected_result->title()); search_box()->SetText(selected_result->title());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment