Commit 078ce2e8 authored by Yutaka Hirano's avatar Yutaka Hirano Committed by Commit Bot

Remove DictionaryHelper::Get(..., ExceptionState&)

No one uses it.

Bug: 775318, 624278
Change-Id: I1efddd76f8a7eba5fbe4a0bf1eb12899b391baa7
Reviewed-on: https://chromium-review.googlesource.com/722299
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarKenichi Ishibashi <bashi@chromium.org>
Reviewed-by: default avatarKouhei Ueno <kouhei@chromium.org>
Reviewed-by: default avatarHitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509289}
parent 4ada703c
...@@ -123,11 +123,6 @@ struct DictionaryHelper { ...@@ -123,11 +123,6 @@ struct DictionaryHelper {
template <typename T> template <typename T>
static bool Get(const Dictionary&, const StringView& key, T& value); static bool Get(const Dictionary&, const StringView& key, T& value);
template <typename T> template <typename T>
static bool Get(const Dictionary&,
const StringView& key,
T& value,
ExceptionState&);
template <typename T>
static bool GetWithUndefinedCheck(const Dictionary& dictionary, static bool GetWithUndefinedCheck(const Dictionary& dictionary,
const StringView& key, const StringView& key,
T& value) { T& value) {
......
...@@ -243,37 +243,6 @@ CORE_EXPORT bool DictionaryHelper::Get(const Dictionary& dictionary, ...@@ -243,37 +243,6 @@ CORE_EXPORT bool DictionaryHelper::Get(const Dictionary& dictionary,
return true; return true;
} }
template <>
CORE_EXPORT bool DictionaryHelper::Get(const Dictionary& dictionary,
const StringView& key,
Vector<Vector<String>>& value,
ExceptionState& exception_state) {
v8::Local<v8::Value> v8_value;
if (!dictionary.Get(key, v8_value))
return false;
if (!v8_value->IsArray())
return false;
v8::Local<v8::Array> v8_array = v8::Local<v8::Array>::Cast(v8_value);
for (size_t i = 0; i < v8_array->Length(); ++i) {
v8::Local<v8::Value> v8_indexed_value;
if (!v8_array
->Get(dictionary.V8Context(),
v8::Uint32::New(dictionary.GetIsolate(), i))
.ToLocal(&v8_indexed_value))
return false;
Vector<String> indexed_value =
NativeValueTraits<IDLSequence<IDLString>>::NativeValue(
dictionary.GetIsolate(), v8_indexed_value, exception_state);
if (exception_state.HadException())
return false;
value.push_back(indexed_value);
}
return true;
}
template <> template <>
CORE_EXPORT bool DictionaryHelper::Get(const Dictionary& dictionary, CORE_EXPORT bool DictionaryHelper::Get(const Dictionary& dictionary,
const StringView& key, const StringView& key,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment