Clang fixes for chromeos

This fixes clang builds with the simple chrome workflow:
cros chrome-sdk --board=link --clang

Unfortunately there are not currently any builders with this
configuration.

BUG=462767

Review URL: https://codereview.chromium.org/967693002

Cr-Commit-Position: refs/heads/master@{#318977}

content/common/gpu/media/generic_v4l2_device.h

@@ -35,7 +35,7 @@ class GenericV4L2Device : public V4L2Device {
                              gfx::Size frame_buffer_size,
                              unsigned int buffer_index,
                              uint32_t v4l2_pixfmt,
-                             size_t num_v4l2_planes);
+                             size_t num_v4l2_planes) override;
   EGLBoolean DestroyEGLImage(EGLDisplay egl_display,
                              EGLImageKHR egl_image) override;
   GLenum GetTextureTarget() override;

content/common/gpu/media/h264_decoder.cc

@@ -1269,6 +1269,10 @@ H264Decoder::DecodeResult H264Decoder::Decode() {
   }
 }
 
+gfx::Size H264Decoder::GetPicSize() const {
+  return pic_size_;
+}
+
 size_t H264Decoder::GetRequiredNumOfPictures() const {
   return dpb_.max_num_pics() + kPicsInPipeline;
 }

content/common/gpu/media/h264_decoder.h

@@ -105,7 +105,7 @@ class CONTENT_EXPORT H264Decoder : public AcceleratedVideoDecoder {
   void Reset() override;
   void SetStream(const uint8_t* ptr, size_t size) override;
   DecodeResult Decode() override WARN_UNUSED_RESULT;
-  gfx::Size GetPicSize() const override { return pic_size_; }
+  gfx::Size GetPicSize() const override;
   size_t GetRequiredNumOfPictures() const override;
 
  private:

content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc

@@ -240,7 +240,7 @@ class V4L2SliceVideoDecodeAccelerator::V4L2H264Accelerator
     : public H264Decoder::H264Accelerator {
  public:
   V4L2H264Accelerator(V4L2SliceVideoDecodeAccelerator* v4l2_dec);
-  virtual ~V4L2H264Accelerator() override;
+  ~V4L2H264Accelerator() override;
 
   // H264Decoder::H264Accelerator implementation.
   scoped_refptr<H264Picture> CreateH264Picture() override;
@@ -322,7 +322,6 @@ class V4L2H264Picture : public H264Picture {
  public:
   V4L2H264Picture(const scoped_refptr<
       V4L2SliceVideoDecodeAccelerator::V4L2DecodeSurface>& dec_surface);
-  virtual ~V4L2H264Picture() override;
 
   V4L2H264Picture* AsV4L2H264Picture() override { return this; }
   scoped_refptr<V4L2SliceVideoDecodeAccelerator::V4L2DecodeSurface>
@@ -331,6 +330,8 @@ class V4L2H264Picture : public H264Picture {
   }
 
  private:
+  ~V4L2H264Picture() override;
+
   scoped_refptr<V4L2SliceVideoDecodeAccelerator::V4L2DecodeSurface>
       dec_surface_;
 
@@ -349,7 +350,6 @@ class V4L2VP8Picture : public VP8Picture {
  public:
   V4L2VP8Picture(const scoped_refptr<
       V4L2SliceVideoDecodeAccelerator::V4L2DecodeSurface>& dec_surface);
-  virtual ~V4L2VP8Picture() override;
 
   V4L2VP8Picture* AsV4L2VP8Picture() override { return this; }
   scoped_refptr<V4L2SliceVideoDecodeAccelerator::V4L2DecodeSurface>
@@ -358,6 +358,8 @@ class V4L2VP8Picture : public VP8Picture {
   }
 
  private:
+  ~V4L2VP8Picture() override;
+
   scoped_refptr<V4L2SliceVideoDecodeAccelerator::V4L2DecodeSurface>
       dec_surface_;
 

content/common/gpu/media/vp8_decoder.cc

@@ -184,6 +184,10 @@ bool VP8Decoder::DecodeAndOutputCurrentFrame() {
   return true;
 }
 
+gfx::Size VP8Decoder::GetPicSize() const {
+  return pic_size_;
+}
+
 size_t VP8Decoder::GetRequiredNumOfPictures() const {
   const size_t kVP8NumFramesActive = 4;
   const size_t kPicsInPipeline = media::limits::kMaxVideoFrames + 2;

content/common/gpu/media/vp8_decoder.h

@@ -66,7 +66,7 @@ class CONTENT_EXPORT VP8Decoder : public AcceleratedVideoDecoder {
   void Reset() override;
   void SetStream(const uint8_t* ptr, size_t size) override;
   DecodeResult Decode() override WARN_UNUSED_RESULT;
-  gfx::Size GetPicSize() const override { return pic_size_; }
+  gfx::Size GetPicSize() const override;
   size_t GetRequiredNumOfPictures() const override;
 
  private:

media/audio/cras/audio_manager_cras.h

@@ -20,34 +20,34 @@ class MEDIA_EXPORT AudioManagerCras : public AudioManagerBase {
   AudioManagerCras(AudioLogFactory* audio_log_factory);
 
   // AudioManager implementation.
-  virtual bool HasAudioOutputDevices() override;
-  virtual bool HasAudioInputDevices() override;
-  virtual void ShowAudioInputSettings() override;
-  virtual void GetAudioInputDeviceNames(
-      AudioDeviceNames* device_names) override;
-  virtual void GetAudioOutputDeviceNames(
-      AudioDeviceNames* device_names) override;
-  virtual AudioParameters GetInputStreamParameters(
+  bool HasAudioOutputDevices() override;
+  bool HasAudioInputDevices() override;
+  void ShowAudioInputSettings() override;
+  void GetAudioInputDeviceNames(AudioDeviceNames* device_names) override;
+  void GetAudioOutputDeviceNames(AudioDeviceNames* device_names) override;
+  AudioParameters GetInputStreamParameters(
       const std::string& device_id) override;
-  virtual void SetHasKeyboardMic() override;
+  void SetHasKeyboardMic() override;
 
   // AudioManagerBase implementation.
-  virtual AudioOutputStream* MakeLinearOutputStream(
+  AudioOutputStream* MakeLinearOutputStream(
       const AudioParameters& params) override;
-  virtual AudioOutputStream* MakeLowLatencyOutputStream(
+  AudioOutputStream* MakeLowLatencyOutputStream(
+      const AudioParameters& params,
+      const std::string& device_id) override;
+  AudioInputStream* MakeLinearInputStream(
+      const AudioParameters& params,
+      const std::string& device_id) override;
+  AudioInputStream* MakeLowLatencyInputStream(
       const AudioParameters& params,
       const std::string& device_id) override;
-  virtual AudioInputStream* MakeLinearInputStream(
-      const AudioParameters& params, const std::string& device_id) override;
-  virtual AudioInputStream* MakeLowLatencyInputStream(
-      const AudioParameters& params, const std::string& device_id) override;
 
   static snd_pcm_format_t BitsToFormat(int bits_per_sample);
 
  protected:
-  virtual ~AudioManagerCras();
+  ~AudioManagerCras() override;
 
-  virtual AudioParameters GetPreferredOutputStreamParameters(
+  AudioParameters GetPreferredOutputStreamParameters(
       const std::string& output_device_id,
       const AudioParameters& input_params) override;
 

media/audio/cras/cras_input.h

@@ -25,22 +25,23 @@ class CrasInputStream : public AgcAudioStream<AudioInputStream> {
  public:
   // The ctor takes all the usual parameters, plus |manager| which is the
   // audio manager who is creating this object.
-  CrasInputStream(const AudioParameters& params, AudioManagerCras* manager,
+  CrasInputStream(const AudioParameters& params,
+                  AudioManagerCras* manager,
                   const std::string& device_id);
 
   // The dtor is typically called by the AudioManager only and it is usually
   // triggered by calling AudioOutputStream::Close().
-  virtual ~CrasInputStream();
+  ~CrasInputStream() override;
 
   // Implementation of AudioInputStream.
-  virtual bool Open() override;
-  virtual void Start(AudioInputCallback* callback) override;
-  virtual void Stop() override;
-  virtual void Close() override;
-  virtual double GetMaxVolume() override;
-  virtual void SetVolume(double volume) override;
-  virtual double GetVolume() override;
-  virtual bool IsMuted() override;
+  bool Open() override;
+  void Start(AudioInputCallback* callback) override;
+  void Stop() override;
+  void Close() override;
+  double GetMaxVolume() override;
+  void SetVolume(double volume) override;
+  double GetVolume() override;
+  bool IsMuted() override;
 
  private:
   // Handles requests to get samples from the provided buffer.  This will be

media/audio/cras/cras_unified.h

@@ -33,15 +33,15 @@ class MEDIA_EXPORT CrasUnifiedStream : public AudioOutputStream {
 
   // The dtor is typically called by the AudioManager only and it is usually
   // triggered by calling AudioUnifiedStream::Close().
-  virtual ~CrasUnifiedStream();
+  ~CrasUnifiedStream() override;
 
   // Implementation of AudioOutputStream.
-  virtual bool Open() override;
-  virtual void Close() override;
-  virtual void Start(AudioSourceCallback* callback) override;
-  virtual void Stop() override;
-  virtual void SetVolume(double volume) override;
-  virtual void GetVolume(double* volume) override;
+  bool Open() override;
+  void Close() override;
+  void Start(AudioSourceCallback* callback) override;
+  void Stop() override;
+  void SetVolume(double volume) override;
+  void GetVolume(double* volume) override;
 
  private:
   // Convert Latency in time to bytes.

ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.h

@@ -48,7 +48,7 @@ class EventReaderLibevdevCros : public EventConverterEvdev {
                           InputDeviceType type,
                           const EventDeviceInfo& devinfo,
                           scoped_ptr<Delegate> delegate);
-  ~EventReaderLibevdevCros();
+  ~EventReaderLibevdevCros() override;
 
   // EventConverterEvdev:
   void OnFileCanReadWithoutBlocking(int fd) override;

ui/events/ozone/evdev/libgestures_glue/gesture_feedback.cc

@@ -23,7 +23,6 @@ namespace {
 
 // Binary paths.
 const char kGzipCommand[] = "/bin/gzip";
-const char kDateCommand[] = "/bin/date";
 
 const size_t kTouchLogTimestampMaxSize = 80;
 

ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc

@@ -680,7 +680,6 @@ class MatchDeviceType : public MatchCriteria {
  public:
   explicit MatchDeviceType(const std::string& arg);
   ~MatchDeviceType() override {}
-  virtual bool Match(const DevicePtr device) = 0;
 
  protected:
   bool value_;