Commit 07a1e235 authored by Henrik Boström's avatar Henrik Boström Committed by Commit Bot

Parameterize WebRtcSetDescriptionObserverHandlerTest.

Handlers exists in two flavors, WebRtcSetLocalDescriptionObserverHandler
which is used for setLocalDescription(), and
WebRtcSetRemoteDescriptionObserverHandler which is used for
setRemoteDescription(). They have the same functionality but have to be
different classes due to webrtc observer interfaces being different
classes.

Each handler can operate in two modes: surfacing transceiver states
(includes senders and receivers) or only surfacing receiver states.

Prior to this CL, only the "remote" handler and "receiver only" mode
was tested. With this CL, all four combinations
"(local/remote) x (transceivers/receivers)" are tested using
parameterized gtests.

This improves test coverage and unblocks testing that is needed to solve
a bug related to surfacing transceivers (https://crbug.com/897251).

Bug: 865006
Change-Id: Iaf40b498b0fef0978c4179c47118f6cff0bcdf66
Reviewed-on: https://chromium-review.googlesource.com/c/1309747
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: default avatarGuido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605350}
parent a3dd9802
...@@ -182,6 +182,13 @@ FakeRtpReceiver::streams() const { ...@@ -182,6 +182,13 @@ FakeRtpReceiver::streams() const {
return streams_; return streams_;
} }
std::vector<std::string> FakeRtpReceiver::stream_ids() const {
std::vector<std::string> stream_ids;
for (const auto& stream : streams_)
stream_ids.push_back(stream->id());
return stream_ids;
}
cricket::MediaType FakeRtpReceiver::media_type() const { cricket::MediaType FakeRtpReceiver::media_type() const {
NOTIMPLEMENTED(); NOTIMPLEMENTED();
return cricket::MEDIA_TYPE_AUDIO; return cricket::MEDIA_TYPE_AUDIO;
......
...@@ -56,6 +56,7 @@ class FakeRtpReceiver : public webrtc::RtpReceiverInterface { ...@@ -56,6 +56,7 @@ class FakeRtpReceiver : public webrtc::RtpReceiverInterface {
rtc::scoped_refptr<webrtc::MediaStreamTrackInterface> track() const override; rtc::scoped_refptr<webrtc::MediaStreamTrackInterface> track() const override;
std::vector<rtc::scoped_refptr<webrtc::MediaStreamInterface>> streams() std::vector<rtc::scoped_refptr<webrtc::MediaStreamInterface>> streams()
const override; const override;
std::vector<std::string> stream_ids() const override;
cricket::MediaType media_type() const override; cricket::MediaType media_type() const override;
std::string id() const override; std::string id() const override;
webrtc::RtpParameters GetParameters() const override; webrtc::RtpParameters GetParameters() const override;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment