[cleanup] Decrease v8.h exposure through blink headers

Exposing v8.h in blink headers increases coupling in chromium and requires
defines from V8 to be present in all includers of those blink headers.

This CL removes "v8/include/v8.h from three headers and moves it into .cc
files instead.

Bug: v8:8788
Change-Id: I1f3e172e414d53cc01493f4ca36ad5a3bad00987
Reviewed-on: https://chromium-review.googlesource.com/c/1475176
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632844}

third_party/blink/public/platform/scheduler/web_rail_mode_observer.h

@@ -6,7 +6,10 @@
 #define THIRD_PARTY_BLINK_PUBLIC_PLATFORM_SCHEDULER_WEB_RAIL_MODE_OBSERVER_H_
 
 #include "third_party/blink/public/platform/web_common.h"
-#include "v8/include/v8.h"
+
+namespace v8 {
+enum RAILMode : unsigned;
+}
 
 namespace blink {
 namespace scheduler {

third_party/blink/public/platform/scheduler/web_thread_scheduler.h

@@ -18,7 +18,6 @@
 #include "third_party/blink/public/platform/web_input_event.h"
 #include "third_party/blink/public/platform/web_input_event_result.h"
 #include "third_party/blink/public/platform/web_scoped_virtual_time_pauser.h"
-#include "v8/include/v8.h"
 
 namespace base {
 namespace trace_event {

third_party/blink/renderer/platform/heap/thread_state.cc

@@ -201,6 +201,21 @@ ThreadState::ThreadState()
   heap_ = std::make_unique<ThreadHeap>(this);
 }
 
+// Implementation for WebRAILModeObserver
+void ThreadState::OnRAILModeChanged(v8::RAILMode new_mode) {
+  should_optimize_for_load_time_ = new_mode == v8::RAILMode::PERFORMANCE_LOAD;
+  // When switching RAIL mode to load we try to avoid incremental marking as
+  // the write barrier cost is noticeable on throughput and garbage
+  // accumulated during loading is likely to be alive during that phase. The
+  // same argument holds for unified heap garbage collections with the
+  // difference that these collections are triggered by V8 and should thus be
+  // avoided on that end.
+  if (should_optimize_for_load_time_ && IsIncrementalMarking() &&
+      !IsUnifiedGCMarkingInProgress() &&
+      GetGCState() == GCState::kIncrementalMarkingStepScheduled)
+    ScheduleIncrementalMarkingFinalize();
+}
+
 ThreadState::~ThreadState() {
   DCHECK(CheckThread());
   if (IsMainThread())

third_party/blink/renderer/platform/heap/thread_state.h

@@ -534,19 +534,7 @@ class PLATFORM_EXPORT ThreadState final
   MarkingVisitor* CurrentVisitor() { return current_gc_data_.visitor.get(); }
 
   // Implementation for WebRAILModeObserver
-  void OnRAILModeChanged(v8::RAILMode new_mode) override {
-    should_optimize_for_load_time_ = new_mode == v8::RAILMode::PERFORMANCE_LOAD;
-    // When switching RAIL mode to load we try to avoid incremental marking as
-    // the write barrier cost is noticeable on throughput and garbage
-    // accumulated during loading is likely to be alive during that phase. The
-    // same argument holds for unified heap garbage collections with the
-    // difference that these collections are triggered by V8 and should thus be
-    // avoided on that end.
-    if (should_optimize_for_load_time_ && IsIncrementalMarking() &&
-        !IsUnifiedGCMarkingInProgress() &&
-        GetGCState() == GCState::kIncrementalMarkingStepScheduled)
-      ScheduleIncrementalMarkingFinalize();
-  }
+  void OnRAILModeChanged(v8::RAILMode new_mode) override;
 
  private:
   // Stores whether some ThreadState is currently in incremental marking.

third_party/blink/renderer/platform/heap/unified_heap_marking_visitor.h

@@ -8,6 +8,10 @@
 #include "base/macros.h"
 #include "third_party/blink/renderer/platform/heap/marking_visitor.h"
 
+namespace v8 {
+class EmbedderHeapTracer;
+}
+
 namespace blink {
 
 struct WrapperTypeInfo;

third_party/blink/renderer/platform/heap/visitor.h

@@ -39,7 +39,10 @@
 #include "third_party/blink/renderer/platform/wtf/forward.h"
 #include "third_party/blink/renderer/platform/wtf/hash_traits.h"
 #include "third_party/blink/renderer/platform/wtf/type_traits.h"
-#include "v8/include/v8.h"
+
+namespace v8 {
+class Value;
+}
 
 namespace blink {
 

third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc

@@ -38,6 +38,7 @@
 #include "third_party/blink/renderer/platform/scheduler/main_thread/main_thread.h"
 #include "third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.h"
 #include "third_party/blink/renderer/platform/scheduler/main_thread/task_type_names.h"
+#include "v8/include/v8.h"
 
 namespace blink {
 namespace scheduler {
@@ -1999,6 +2000,14 @@ void MainThreadSchedulerImpl::TaskQueuePolicy::AsValueInto(
   state->SetBoolean("use_virtual_time", use_virtual_time);
 }
 
+MainThreadSchedulerImpl::Policy::Policy()
+    : rail_mode_(v8::PERFORMANCE_ANIMATION),
+      should_disable_throttling_(false),
+      frozen_when_backgrounded_(false),
+      compositor_priority_(
+          base::sequence_manager::TaskQueue::QueuePriority::kNormalPriority),
+      use_case_(UseCase::kNone) {}
+
 void MainThreadSchedulerImpl::Policy::AsValueInto(
     base::trace_event::TracedValue* state) const {
   state->BeginDictionary("compositor_queue_policy");

third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h

@@ -457,14 +457,7 @@ class PLATFORM_EXPORT MainThreadSchedulerImpl
 
   class Policy {
    public:
-    Policy()
-        : rail_mode_(v8::PERFORMANCE_ANIMATION),
-          should_disable_throttling_(false),
-          frozen_when_backgrounded_(false),
-          compositor_priority_(base::sequence_manager::TaskQueue::
-                                   QueuePriority::kNormalPriority),
-          use_case_(UseCase::kNone) {}
-
+    Policy();
     ~Policy() = default;
 
     TaskQueuePolicy& compositor_queue_policy() {

third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc

@@ -34,6 +34,7 @@
 #include "third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.h"
 #include "third_party/blink/renderer/platform/scheduler/main_thread/frame_task_queue_controller.h"
 #include "third_party/blink/renderer/platform/testing/runtime_enabled_features_test_helpers.h"
+#include "v8/include/v8.h"
 
 using base::sequence_manager::TaskQueue;