Commit 07a4cb0b authored by shuchen's avatar shuchen Committed by Commit bot

Enables new Korean IME by default for M44.

TBR=suzhe@chromium.org
BUG=407456
TEST=Verified on linux_chromeos & clapper device.

Review URL: https://codereview.chromium.org/1132333002

Cr-Commit-Position: refs/heads/master@{#329810}
parent 3cea41ac
......@@ -14473,11 +14473,11 @@ After you create a new supervised user, you can manage their settings at any tim
Disable input view keyboards in material design.
</message>
<message name="IDS_FLAGS_ENABLE_NEW_KOREAN_IME_NAME" desc="Name of about::flags option to enable the new Korean IME">
Enable new Korean IME.
<message name="IDS_FLAGS_DISABLE_NEW_KOREAN_IME_NAME" desc="Name of about::flags option to disable the new Korean IME">
Disable new Korean IME.
</message>
<message name="IDS_FLAGS_ENABLE_NEW_KOREAN_IME_DESCRIPTION" desc="Description of about::flags option to enable the new Korean IME">
Enable new Korean IME, which is based on Google Input Tools' HMM engine.
<message name="IDS_FLAGS_DISABLE_NEW_KOREAN_IME_DESCRIPTION" desc="Description of about::flags option to disable the new Korean IME">
Disable new Korean IME, which is based on Google Input Tools' HMM engine.
</message>
<message name="IDS_FLAGS_ENABLE_PHYSICAL_KEYBOARD_AUTOCORRECT_NAME" desc="Name of about::flags option to enable physical keyboard autocorrect for US keyboard">
......@@ -1410,11 +1410,11 @@ const Experiment kExperiments[] = {
keyboard::switches::kDisableInputView)
},
{
"enable-new-korean-ime",
IDS_FLAGS_ENABLE_NEW_KOREAN_IME_NAME,
IDS_FLAGS_ENABLE_NEW_KOREAN_IME_DESCRIPTION,
"disable-new-korean-ime",
IDS_FLAGS_DISABLE_NEW_KOREAN_IME_NAME,
IDS_FLAGS_DISABLE_NEW_KOREAN_IME_DESCRIPTION,
kOsCrOS,
SINGLE_VALUE_TYPE(chromeos::switches::kEnableNewKoreanIme)
SINGLE_VALUE_TYPE(chromeos::switches::kDisableNewKoreanIme)
},
{
"disable-new-md-input-view",
......
......@@ -442,8 +442,8 @@
<include name="IDR_ZHUYIN_MANIFEST" file="resources\chromeos\input_method\zhuyin_manifest.json" type="BINDATA" />
<include name="IDR_CANGJIE_MANIFEST" file="resources\chromeos\input_method\cangjie_manifest.json" type="BINDATA" />
<include name="IDR_MOZC_MANIFEST" file="resources\chromeos\input_method\mozc_manifest.json" type="BINDATA" />
<include name="IDR_HANGUL_MANIFEST" file="resources\chromeos\input_method\hangul_manifest.json" type="BINDATA" />
</if>
<include name="IDR_HANGUL_MANIFEST" file="resources\chromeos\input_method\hangul_manifest.json" type="BINDATA" />
<include name="IDR_BRAILLE_MANIFEST" file="resources\chromeos\braille_ime\manifest.json" type="BINDATA" />
</if>
<include name="IDR_WHISPERNET_PROXY_MANIFEST" file="resources\whispernet_proxy\manifest.json" type="BINDATA" />
......
......@@ -111,9 +111,9 @@ const char kEnableConsumerManagement[] = "enable-consumer-management";
// If this switch is set, the device cannot be remotely disabled by its owner.
const char kDisableDeviceDisabling[] = "disable-device-disabling";
// If this switch is set, the new Korean IME will be available in
// If this switch is set, the new Korean IME will not be available in
// chrome://settings/languages.
const char kEnableNewKoreanIme[] = "enable-new-korean-ime";
const char kDisableNewKoreanIme[] = "disable-new-korean-ime";
// Disables mtp write support.
const char kDisableMtpWriteSupport[] = "disable-mtp-write-support";
......
......@@ -61,7 +61,7 @@ CHROMEOS_EXPORT extern const char kEnableFirewallHolePunching[];
CHROMEOS_EXPORT extern const char kEnableFirstRunUITransitions[];
CHROMEOS_EXPORT extern const char kEnableKioskMode[];
CHROMEOS_EXPORT extern const char kEnableNetworkPortalNotification[];
CHROMEOS_EXPORT extern const char kEnableNewKoreanIme[];
CHROMEOS_EXPORT extern const char kDisableNewKoreanIme[];
CHROMEOS_EXPORT extern const char kEnablePhysicalKeyboardAutocorrect[];
CHROMEOS_EXPORT extern const char kEnablePrinterAppSearch[];
CHROMEOS_EXPORT extern const char kEnableRequestTabletSite[];
......
......@@ -56630,6 +56630,7 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="834326277" label="enable-answers-in-suggest"/>
<int value="835018878" label="disable-quic"/>
<int value="838887742" label="manual-enhanced-bookmarks"/>
<int value="841343322" label="disable-new-korean-ime"/>
<int value="851085848" label="enable-settings-window"/>
<int value="855746780" label="disable-physical-keyboard-autocorrect"/>
<int value="857445869" label="enable-captive-portal-bypass-proxy"/>
......@@ -166,8 +166,8 @@ bool ComponentExtensionIMEManager::IsWhitelistedExtension(
input_method::InputMethodDescriptors
ComponentExtensionIMEManager::GetAllIMEAsInputMethodDescriptor() {
bool enable_new_korean_ime =
base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableNewKoreanIme);
!base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kDisableNewKoreanIme);
input_method::InputMethodDescriptors result;
for (std::map<std::string, ComponentExtensionIME>::const_iterator it =
component_extension_imes_.begin();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment