Annotate Trusteer Rapport < 3.6 as incompatible with Chrome.

BUG=671194
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
TEST=manual, install Trusteer Rapport, verify dialog appears.

Review-Url: https://codereview.chromium.org/2566733003
Cr-Commit-Position: refs/heads/master@{#437729}

chrome/browser/win/enumerate_modules_model.cc

@@ -518,6 +518,7 @@ void ModuleEnumerator::ScanImplModule(size_t index) {
 
 void ModuleEnumerator::ScanImplFinish() {
   // TODO(chrisha): Annotate any modules that are suspicious/bad.
+  AnnotateBadModules();
 
   ReportThirdPartyMetrics();
 
@@ -694,6 +695,19 @@ void ModuleEnumerator::CollapsePath(Module* entry) {
   }
 }
 
+void ModuleEnumerator::AnnotateBadModules() {
+  for (auto& module : *enumerated_modules_) {
+    if (module.name == L"rapportnikko.dll") {
+      base::Version version(base::UTF16ToASCII(module.version));
+      base::Version good("3.6");
+      if (version.CompareTo(good) < 0) {
+        module.status = ModuleStatus::CONFIRMED_BAD;
+        module.recommended_action = RecommendedAction::UNINSTALL;
+      }
+    }
+  }
+}
+
 void ModuleEnumerator::ReportThirdPartyMetrics() {
   static const wchar_t kMicrosoft[] = L"Microsoft ";
   static const wchar_t kGoogle[] = L"Google Inc";

chrome/browser/win/enumerate_modules_model.h

@@ -221,6 +221,9 @@ class ModuleEnumerator {
   // based on the |path_mapping_| vector.
   void CollapsePath(Module* module);
 
+  // Annotate any known third party modules with actions the user can take.
+  void AnnotateBadModules();
+
   // Reports (via UMA) a handful of high-level metrics regarding third party
   // modules in this process. Called by ScanImplFinish.
   void ReportThirdPartyMetrics();