Fix misuse of std::remove_if and std::erase

It was pure coincidence that it worked in the past.

Change-Id: I97d2b649055bf7ca527f5a8ad214252929d35f26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134777
Auto-Submit: John Wu <jzw@chromium.org>
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756557}

ios/web_view/internal/sync/web_view_sync_client.mm

@@ -147,7 +147,8 @@ WebViewSyncClient::CreateDataTypeControllers(
                                    [](const auto& data_type_controller) {
                                      return data_type_controller->type() ==
                                             syncer::USER_CONSENTS;
-                                   }));
+                                   }),
+                    type_vector.end());
   return type_vector;
 }