Commit 07a7451a authored by Sinan Sahin's avatar Sinan Sahin Committed by Commit Bot

[Context menu redesign] Fix missing header title issues

The Revamped context menu header doesn't show a title if the image/video
doesn't have alt/title.

This CL fixes the issue by using the name of the image/video extracted
from the source URL if the alt/title is empty.

Bug: 971500
Change-Id: I366532d3fbbd5b19e7b542c533df20ac020c21df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664991Reviewed-by: default avatarTheresa <twellington@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#670249}
parent bcb1e087
...@@ -11,6 +11,7 @@ import android.text.SpannableString; ...@@ -11,6 +11,7 @@ import android.text.SpannableString;
import android.text.TextUtils; import android.text.TextUtils;
import android.view.LayoutInflater; import android.view.LayoutInflater;
import android.view.View; import android.view.View;
import android.webkit.URLUtil;
import org.chromium.base.Callback; import org.chromium.base.Callback;
import org.chromium.chrome.R; import org.chromium.chrome.R;
...@@ -49,8 +50,13 @@ class RevampedContextMenuHeaderCoordinator { ...@@ -49,8 +50,13 @@ class RevampedContextMenuHeaderCoordinator {
} }
private String getTitle(ContextMenuParams params) { private String getTitle(ContextMenuParams params) {
return TextUtils.isEmpty(params.getTitleText()) ? params.getLinkText() if (!TextUtils.isEmpty(params.getTitleText())) {
: params.getTitleText(); return params.getTitleText();
}
if (!TextUtils.isEmpty(params.getLinkText())) {
return params.getLinkText();
}
return URLUtil.guessFileName(params.getSrcUrl(), null, null);
} }
private CharSequence getUrl(Activity activity, ContextMenuParams params) { private CharSequence getUrl(Activity activity, ContextMenuParams params) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment