Commit 07c61c55 authored by Tim van der Lippe's avatar Tim van der Lippe Committed by Commit Bot

Remove SplitInDrawer experiment

With the removal of the terminal, we no longer need this experiment.

BUG=1011466

Change-Id: I0c097d33d09329eae41079504d825041f082e1fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866930
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: default avatarPaul Irish <paulirish@chromium.org>
Reviewed-by: default avatarYang Guo <yangguo@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707292}
parent 6387ffdf
...@@ -136,7 +136,6 @@ Main.Main = class { ...@@ -136,7 +136,6 @@ Main.Main = class {
'recordCoverageWithPerformanceTracing', 'Record coverage while performance tracing'); 'recordCoverageWithPerformanceTracing', 'Record coverage while performance tracing');
Root.Runtime.experiments.register('samplingHeapProfilerTimeline', 'Sampling heap profiler timeline', true); Root.Runtime.experiments.register('samplingHeapProfilerTimeline', 'Sampling heap profiler timeline', true);
Root.Runtime.experiments.register('sourceDiff', 'Source diff'); Root.Runtime.experiments.register('sourceDiff', 'Source diff');
Root.Runtime.experiments.register('splitInDrawer', 'Split in drawer', true);
Root.Runtime.experiments.register('spotlight', 'Spotlight', true); Root.Runtime.experiments.register('spotlight', 'Spotlight', true);
// Timeline // Timeline
......
...@@ -44,16 +44,6 @@ export default class InspectorView extends UI.VBox { ...@@ -44,16 +44,6 @@ export default class InspectorView extends UI.VBox {
this._drawerSplitWidget.enableShowModeSaving(); this._drawerSplitWidget.enableShowModeSaving();
this._drawerSplitWidget.show(this.element); this._drawerSplitWidget.show(this.element);
if (Root.Runtime.experiments.isEnabled('splitInDrawer')) {
this._innerDrawerSplitWidget = new UI.SplitWidget(true, true, 'Inspector.drawerSidebarSplitViewState', 200, 200);
this._drawerSplitWidget.setSidebarWidget(this._innerDrawerSplitWidget);
this._drawerSidebarTabbedLocation =
UI.viewManager.createTabbedLocation(this._showDrawer.bind(this, false), 'drawer-sidebar', true, true);
this._drawerSidebarTabbedPane = this._drawerSidebarTabbedLocation.tabbedPane();
this._drawerSidebarTabbedPane.addEventListener(UI.TabbedPane.Events.TabSelected, this._drawerTabSelected, this);
this._innerDrawerSplitWidget.setSidebarWidget(this._drawerSidebarTabbedPane);
}
// Create drawer tabbed pane. // Create drawer tabbed pane.
this._drawerTabbedLocation = this._drawerTabbedLocation =
UI.viewManager.createTabbedLocation(this._showDrawer.bind(this, false), 'drawer-view', true, true); UI.viewManager.createTabbedLocation(this._showDrawer.bind(this, false), 'drawer-view', true, true);
...@@ -66,14 +56,8 @@ export default class InspectorView extends UI.VBox { ...@@ -66,14 +56,8 @@ export default class InspectorView extends UI.VBox {
this._drawerSplitWidget.installResizer(this._drawerTabbedPane.headerElement()); this._drawerSplitWidget.installResizer(this._drawerTabbedPane.headerElement());
this._drawerTabbedPane.addEventListener(UI.TabbedPane.Events.TabSelected, this._drawerTabSelected, this); this._drawerTabbedPane.addEventListener(UI.TabbedPane.Events.TabSelected, this._drawerTabSelected, this);
if (this._drawerSidebarTabbedPane) { this._drawerSplitWidget.setSidebarWidget(this._drawerTabbedPane);
this._innerDrawerSplitWidget.setMainWidget(this._drawerTabbedPane); this._drawerTabbedPane.rightToolbar().appendToolbarItem(closeDrawerButton);
this._drawerSidebarTabbedPane.rightToolbar().appendToolbarItem(closeDrawerButton);
this._drawerSplitWidget.installResizer(this._drawerSidebarTabbedPane.headerElement());
} else {
this._drawerSplitWidget.setSidebarWidget(this._drawerTabbedPane);
this._drawerTabbedPane.rightToolbar().appendToolbarItem(closeDrawerButton);
}
// Create main area tabbed pane. // Create main area tabbed pane.
this._tabbedLocation = UI.viewManager.createTabbedLocation( this._tabbedLocation = UI.viewManager.createTabbedLocation(
...@@ -140,9 +124,6 @@ export default class InspectorView extends UI.VBox { ...@@ -140,9 +124,6 @@ export default class InspectorView extends UI.VBox {
if (locationName === 'panel') { if (locationName === 'panel') {
return this._tabbedLocation; return this._tabbedLocation;
} }
if (locationName === 'drawer-sidebar') {
return this._drawerSidebarTabbedLocation;
}
return null; return null;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment